public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "f.heckenbach@fh-soft.de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/106774] warning about comparison to true/false Date: Tue, 30 Aug 2022 00:02:22 +0000 [thread overview] Message-ID: <bug-106774-4-TvQ80qKVV2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106774-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106774 --- Comment #2 from Frank Heckenbach <f.heckenbach@fh-soft.de> --- This should cover all cases mentioned: void t (bool a, int i, float e, double f) { // Boolean literal comparisons if (a == true) // better: if (a) return; if (a == false) // better: if (!a) return; if (a != true) // better: if (!a) return; if (a != false) // better: if (a) return; // also reversed to be sure if (true == a) // better: if (a) return; if (false != a) // better: if (a) return; // Integer comparisons to Boolean literals if (i == true) // better: if (i == 1) return; if (i == false) // better: if (i == 0) or: if (!i) return; if (i != true) // better: if (i != 1) return; if (i != false) // better: if (i != 0) or: if (i) return; // Floating-point comparisons to Boolean literals if (e == true) // very strange at all, if meant so, then better: if (e == 1.0f) return; if (f == false) // very strange at all, if meant so, then better: if (f == 0.0) return; }
next prev parent reply other threads:[~2022-08-30 0:02 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-29 23:48 [Bug c++/106774] New: " f.heckenbach@fh-soft.de 2022-08-29 23:52 ` [Bug c++/106774] " pinskia at gcc dot gnu.org 2022-08-30 0:02 ` f.heckenbach@fh-soft.de [this message] 2022-08-30 7:09 ` rguenth at gcc dot gnu.org 2022-08-30 23:50 ` egallager at gcc dot gnu.org 2022-08-31 10:33 ` redi at gcc dot gnu.org 2022-08-31 23:46 ` f.heckenbach@fh-soft.de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106774-4-TvQ80qKVV2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).