public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/106794] [13 Regression] ICE in vect_transform_slp_perm_load_1 since r13-2288-g61c4c989034548f4 Date: Tue, 20 Sep 2022 14:28:04 +0000 [thread overview] Message-ID: <bug-106794-4-2y9COq5n24@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106794-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106794 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>: https://gcc.gnu.org/g:1005c89431cc78a68762643e1bc7249c3959927e commit r13-2738-g1005c89431cc78a68762643e1bc7249c3959927e Author: Richard Sandiford <richard.sandiford@arm.com> Date: Tue Sep 20 15:27:47 2022 +0100 vect: Fix SLP layout handling of masked loads [PR106794] PR106794 shows that I'd forgotten about masked loads when doing the SLP layout changes. These loads can't currently be permuted independently of their mask input, so during construction they never get a load permutation. (If we did support permuting masked loads in future, the mask would need to be in the right order for the load, rather than in the order implied by the result of the permutation. Since masked loads can't be partly or fully scalarised in the way that normal permuted loads can be, there's probably no benefit to fusing the permutation and the load. Permutation after the fact is probably good enough.) gcc/ PR tree-optimization/106794 PR tree-optimization/106914 * tree-vect-slp.cc (vect_optimize_slp_pass::internal_node_cost): Only consider loads that already have a permutation. (vect_optimize_slp_pass::start_choosing_layouts): Assert that loads with permutations are leaf nodes. Prevent any kind of grouped access from changing layout if it doesn't have a load permutation. gcc/testsuite/ * gcc.dg/vect/pr106914.c: New test. * g++.dg/vect/pr106794.cc: Likewise.
next prev parent reply other threads:[~2022-09-20 14:28 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-31 16:18 [Bug c++/106794] New: ice in vect_transform_slp_perm_load_1 dcb314 at hotmail dot com 2022-08-31 16:23 ` [Bug c++/106794] " dcb314 at hotmail dot com 2022-08-31 16:28 ` [Bug tree-optimization/106794] [13 Regression] " pinskia at gcc dot gnu.org 2022-08-31 16:58 ` dcb314 at hotmail dot com 2022-08-31 20:32 ` [Bug tree-optimization/106794] [13 Regression] ICE in vect_transform_slp_perm_load_1 since r13-2288-g61c4c989034548f4 marxin at gcc dot gnu.org 2022-09-13 10:20 ` rsandifo at gcc dot gnu.org 2022-09-14 12:24 ` rsandifo at gcc dot gnu.org 2022-09-20 14:28 ` cvs-commit at gcc dot gnu.org [this message] 2022-09-20 14:29 ` rsandifo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106794-4-2y9COq5n24@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).