[Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
@ 2022-09-02 12:26 seurer at gcc dot gnu.org
  2022-09-02 13:26 ` [Bug other/106814] " aldyh at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-09-02 12:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

            Bug ID: 106814
           Summary: [13 regression] r13-2266-g8bb1df032cc080 breaks some
                    mpfr tests
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:8bb1df032cc080b751e00c0d7d86c31a630105f9, r13-2266-g8bb1df032cc080 

This commit broke some of the mpfr tests on a bootstrap build.

Error in check_misc for +0.
  mpfr_get_decimal128() returned: 0.0
  mpfr_set_decimal128() set x to: -0 approx.
    = -0
FAIL tget_set_d128 (exit status: 1)

Error in check_misc for +0.
  mpfr_get_decimal64() returned:
|1010001000110100000000000000000000000000000000000000000000000000|
  mpfr_set_decimal64() set x to: -0 approx.
    = -0
FAIL tget_set_d64 (exit status: 1)



commit 8bb1df032cc080b751e00c0d7d86c31a630105f9 (HEAD)
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Tue Aug 30 08:23:33 2022 +0200

    Add support for floating point endpoints to frange.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
@ 2022-09-02 13:26 ` aldyh at gcc dot gnu.org
  2022-09-02 13:59 ` seurer at gcc dot gnu.org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-09-02 13:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #1 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
How do I reproduce this?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
  2022-09-02 13:26 ` [Bug other/106814] " aldyh at gcc dot gnu.org
@ 2022-09-02 13:59 ` seurer at gcc dot gnu.org
  2022-09-02 14:00 ` seurer at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-09-02 13:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #2 from seurer at gcc dot gnu.org ---
Do a bootstrap build then

make checkmpfr

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
  2022-09-02 13:26 ` [Bug other/106814] " aldyh at gcc dot gnu.org
  2022-09-02 13:59 ` seurer at gcc dot gnu.org
@ 2022-09-02 14:00 ` seurer at gcc dot gnu.org
  2022-09-02 14:01 ` jakub at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-09-02 14:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #3 from seurer at gcc dot gnu.org ---
Sorry, that's make check-mpfr

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2022-09-02 14:00 ` seurer at gcc dot gnu.org
@ 2022-09-02 14:01 ` jakub at gcc dot gnu.org
  2022-09-02 14:13 ` seurer at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-09-02 14:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
With in-tree mpfr?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2022-09-02 14:01 ` jakub at gcc dot gnu.org
@ 2022-09-02 14:13 ` seurer at gcc dot gnu.org
  2022-09-03 13:46 ` aldyh at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-09-02 14:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #5 from seurer at gcc dot gnu.org ---
I used download_prerequistes before the build.

seurer@rain6p1:~/gcc/git/gcc-test$ ./contrib/download_prerequisites --force
2022-09-02 09:12:04
URL:http://gcc.gnu.org/pub/gcc/infrastructure/gmp-6.2.1.tar.bz2
[2493916/2493916] -> "gmp-6.2.1.tar.bz2" [1]
2022-09-02 09:12:05
URL:http://gcc.gnu.org/pub/gcc/infrastructure/mpfr-4.1.0.tar.bz2
[1747243/1747243] -> "mpfr-4.1.0.tar.bz2" [1]
2022-09-02 09:12:06
URL:http://gcc.gnu.org/pub/gcc/infrastructure/mpc-1.2.1.tar.gz [838731/838731]
-> "mpc-1.2.1.tar.gz" [1]
2022-09-02 09:12:07
URL:http://gcc.gnu.org/pub/gcc/infrastructure/isl-0.24.tar.bz2
[2261594/2261594] -> "isl-0.24.tar.bz2" [1]
gmp-6.2.1.tar.bz2: OK
mpfr-4.1.0.tar.bz2: OK
mpc-1.2.1.tar.gz: OK
isl-0.24.tar.bz2: OK
All prerequisites downloaded successfully.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2022-09-02 14:13 ` seurer at gcc dot gnu.org
@ 2022-09-03 13:46 ` aldyh at gcc dot gnu.org
  2022-09-03 15:53 ` aldyh at gcc dot gnu.org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-09-03 13:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=106819

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
This may be a DUP of 106819.  Does the patch in it solve this PR?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2022-09-03 13:46 ` aldyh at gcc dot gnu.org
@ 2022-09-03 15:53 ` aldyh at gcc dot gnu.org
  2022-09-03 21:06 ` seurer at gcc dot gnu.org
  2022-09-04 19:10 ` aldyh at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-09-03 15:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Aldy Hernandez from comment #6)
> This may be a DUP of 106819.  Does the patch in it solve this PR?

Patch committed upstream btw...

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2022-09-03 15:53 ` aldyh at gcc dot gnu.org
@ 2022-09-03 21:06 ` seurer at gcc dot gnu.org
  2022-09-04 19:10 ` aldyh at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-09-03 21:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

--- Comment #8 from seurer at gcc dot gnu.org ---
I tried dae8b9e2bbb6017bf90d68c7b720c500125c8295, r13-2390-gdae8b9e2bbb601 and
I am still seeing the failures.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug other/106814] [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests
  2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2022-09-03 21:06 ` seurer at gcc dot gnu.org
@ 2022-09-04 19:10 ` aldyh at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-09-04 19:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106814

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #9 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Reproduced with an installed stage1 compiler and then doing:

PATH=/install/path:$PATH
LD_LIBRARY_PATH=/install/lib64
make clean-mpfr
make check-mpfr

But now it's been fixed by:

commit 8293a9632c46c8f3f9d531c09194aa8738944927
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Sun Sep 4 08:00:02 2022 +0200

    Do not clobber signbit when unioning a NAN.

    When unioning a known NAN and something else, we're dropping the
    properties of the NAN, particularly the sign.  This fixes the
    oversight.

    With this patch, we should be keeping the sign bit up to date, even in
    the presence of NANs.

    gcc/ChangeLog:

        * value-range.cc (frange::union_): Do not drop properties when
        unioning a NAN with something else.
        (range_tests_signed_zeros): Add tests.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-09-04 19:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 12:26 [Bug other/106814] New: [13 regression] r13-2266-g8bb1df032cc080 breaks some mpfr tests seurer at gcc dot gnu.org
2022-09-02 13:26 ` [Bug other/106814] " aldyh at gcc dot gnu.org
2022-09-02 13:59 ` seurer at gcc dot gnu.org
2022-09-02 14:00 ` seurer at gcc dot gnu.org
2022-09-02 14:01 ` jakub at gcc dot gnu.org
2022-09-02 14:13 ` seurer at gcc dot gnu.org
2022-09-03 13:46 ` aldyh at gcc dot gnu.org
2022-09-03 15:53 ` aldyh at gcc dot gnu.org
2022-09-03 21:06 ` seurer at gcc dot gnu.org
2022-09-04 19:10 ` aldyh at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).