[Bug target/106815] New: [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[Bug target/106815] New: [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106815

            Bug ID: 106815
           Summary: [13 Regression] ICE: in riscv_excess_precision, at
                    config/riscv/riscv.cc:5967 with -fexcess-precision=16
                    on any input
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: riscv64-unknown-linux-gnu

Compiler output (empty testcase.c):
$ echo '' > testcase.c
$ riscv64-unknown-linux-gnu-gcc -fexcess-precision=16 testcase.c
<built-in>: internal compiler error: in riscv_excess_precision, at
config/riscv/riscv.cc:5967
0x7ada41 riscv_excess_precision
        /repo/gcc-trunk/gcc/config/riscv/riscv.cc:5967
0x7ada41 riscv_excess_precision
        /repo/gcc-trunk/gcc/config/riscv/riscv.cc:5956
0x94a206 c_ts18661_flt_eval_method
        /repo/gcc-trunk/gcc/c-family/c-common.cc:8939
0x98484a c_cpp_builtins(cpp_reader*)
        /repo/gcc-trunk/gcc/c-family/c-cppbuiltin.cc:1223
0x99fec7 c_finish_options
        /repo/gcc-trunk/gcc/c-family/c-opts.cc:1496
0x9a28b0 c_common_parse_file()
        /repo/gcc-trunk/gcc/c-family/c-opts.cc:1249
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ riscv64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-riscv64/bin/riscv64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-2374-20220902172530-gd72ca12b846-checking-yes-rtl-df-extra-riscv64/bin/../libexec/gcc/riscv64-unknown-linux-gnu/13.0.0/lto-wrapper
Target: riscv64-unknown-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --with-isa-spec=2.2
--with-sysroot=/usr/riscv64-unknown-linux-gnu --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=riscv64-unknown-linux-gnu
--with-ld=/usr/bin/riscv64-unknown-linux-gnu-ld
--with-as=/usr/bin/riscv64-unknown-linux-gnu-as --disable-multilib
--disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-2374-20220902172530-gd72ca12b846-checking-yes-rtl-df-extra-riscv64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220902 (experimental) (GCC)

[Bug target/106815] [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[palmer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106815

palmer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palmer at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-09-03

--- Comment #1 from palmer at gcc dot gnu.org ---
Thanks.  I'm pretty sure all we need is

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 675d92c0961..9b6d3e95b1b 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -5962,6 +5962,7 @@ riscv_excess_precision (enum excess_precision_type type)
       return (TARGET_ZFH ? FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16
                         : FLT_EVAL_METHOD_PROMOTE_TO_FLOAT);
     case EXCESS_PRECISION_TYPE_IMPLICIT:
+    case EXCESS_PRECISION_TYPE_FLOAT16:
       return FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16;
     default:
       gcc_unreachable ();

I'll send it out assuming it passes the tests.

[Bug target/106815] [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106815

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/106815] [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106815

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Palmer Dabbelt <palmer@gcc.gnu.org>:

https://gcc.gnu.org/g:75c0899493cd84e64bd30210e848d0d1e9979494

commit r13-3000-g75c0899493cd84e64bd30210e848d0d1e9979494
Author: Palmer Dabbelt <palmer@rivosinc.com>
Date:   Fri Sep 9 02:43:26 2022 -0700

    RISC-V: Support -fexcess-precision=16

    This fixes f19a327077e ("Support -fexcess-precision=16 which will enable
    FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16 when backend supports _Float16.") on
    RISC-V targets.

    gcc/ChangeLog

            PR target/106815
            * config/riscv/riscv.cc (riscv_excess_precision): Add support
            for EXCESS_PRECISION_TYPE_FLOAT16.

[Bug target/106815] [13 Regression] ICE: in riscv_excess_precision, at config/riscv/riscv.cc:5967 with -fexcess-precision=16 on any input

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106815

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
So fixed.(?)