From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 877CC3858D34; Sun, 14 Apr 2024 16:50:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 877CC3858D34
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1713113426;
	bh=ghJYrrFXv62bfuf5DZicRsta8o7rjymtjHiRfPpcwxA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=eKIcres9noxsvCqR8TcHoVYLAkHtEtnK2pQCJv0Hn6AmWz5dRydxdVnU5JeGI4Els
	 ck8VESrggT5rUUTNvaifD6zm9ovZPWXthF7gvHchxgYg1Dcuxp1MSWl+PuXUruKOE2
	 P97AlWeL5alfZyLoNmdMXtF4mwcVeAJap8VmLhuw=
From: "ppalka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106820] [modules] ICE  in function_and_variable_visibility
 with modules and weakref
Date: Sun, 14 Apr 2024 16:50:24 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.2.0
X-Bugzilla-Keywords: ice-on-valid-code, visibility
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ppalka at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106820-4-7YVVgMDgmq@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106820-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106820-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106820

--- Comment #10 from Patrick Palka <ppalka at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:62a0ef0d02cbb74cd865c1db2ecb7ca1b11f87cd

commit r14-9959-g62a0ef0d02cbb74cd865c1db2ecb7ca1b11f87cd
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Sat Feb 17 23:10:49 2024 +1100

    c++: Setup aliases imported from modules [PR106820]

    I wonder if more generally we need to be doing more work when importing
    definitions from header units especially to handle all the work that
    'make_rtl_for_nonlocal_decl' and 'rest_of_decl_compilation' would have
    been performing. But this patch fixes at least one missing step.

            PR c++/106820

    gcc/cp/ChangeLog:

            * module.cc (trees_in::decl_value): Assemble alias when needed.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/pr106820_a.H: New test.
            * g++.dg/modules/pr106820_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>=