From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 133A1385803D; Thu, 22 Sep 2022 12:47:03 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 133A1385803D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1663850823;
	bh=E+MQlU1SqAuFE7paHS3bXAy/s9KK/ilAZrCfC7hUBqM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=c4j1Wms3XLws8uJmGMasKYZd3MUZySCL6XSL27Etb2YyTxh4ko4ge/lAIvrEGXsld
	 f+ShGHXx7flBxhXglhYz2kdYD07TTPYha+qGZKMbTbLuvAr+KPFuH418ze7yYFXray
	 W7TXF9Ro4wOeQ7fzy63HVyfZMtJQSX17wg7JnQ74=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106826] [13 Regression] [modules] Variable template of type
 trait via importable header gives wrong result
Date: Thu, 22 Sep 2022 12:47:02 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106826-4-q7Vbrf83D4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106826-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106826-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106826

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:32d8123cd6ce87acb557aec230e8359051316f9f

commit r13-2775-g32d8123cd6ce87acb557aec230e8359051316f9f
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Sep 22 08:46:23 2022 -0400

    c++ modules: partial variable template specializations [PR106826]

    With partial variable template specializations, it looks like we
    stream the VAR_DECL (i.e. the DECL_TEMPLATE_RESULT of the corresponding
    TEMPLATE_DECL) since process_partial_specialization adds it to the
    specializations table, but we end up never streaming the corresponding
    TEMPLATE_DECL itself that's reachable only from the primary template's
    DECL_TEMPLATE_SPECIALIZATIONS list, which leads to this list being
    incomplete on stream-in.

    The modules machinery already has special logic for streaming partial
    specializations of class templates; this patch attempts to generalize
    it to handle those of variable templates as well.

            PR c++/106826

    gcc/cp/ChangeLog:

            * module.cc (trees_out::decl_value): Use get_template_info in
            the MK_partial case to handle both VAR_DECL and TYPE_DECL.
            (trees_out::key_mergeable): Likewise.
            (trees_in::key_mergeable): Likewise.
            (has_definition): Consider DECL_INITIAL of a partial variable
            template specialization.
            (depset::hash::make_dependency): Handle partial variable templa=
te
            specializations too.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/partial-2_a.C: New test.
            * g++.dg/modules/partial-2_b.C: New test.=