From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id EB7603858011; Tue, 6 Sep 2022 03:40:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB7603858011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662435658; bh=ns3gwFLR85mBfum+Ug3ZXGt4ZIdGdHDSMxV69y/azrQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=gX6kzeYAxB4Vg8UT7YrBtbbIHxunNDp7JwsG8w0M9nWRaAPZnXrKOnnlydELSdnwn oYUvQxFKpfc/cd47WuK3fZ8v4qOnZP/ogNytJsQaJC0oY6xjQZSfuKXc94bGcF0/Js TqX6r6qhoCAwTosTrbTd/Lzr6GknZ6mS0de8ZSig= From: "linkw at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/106833] Handle OPAQUE_TYPE in gimple_canonical_types_compatible_p Date: Tue, 06 Sep 2022 03:40:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: ice-checking X-Bugzilla-Severity: normal X-Bugzilla-Who: linkw at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106833 --- Comment #8 from Kewen Lin --- Created attachment 53542 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D53542&action=3Dedit Specially handle opaque type in verify_type (In reply to Segher Boessenkool from comment #7) > (In reply to rguenther@suse.de from comment #6) > > Ah, that special "mode". I think verify_types shouldn't do anything > > for OPAQUE_TYPES or alternatively trust the targets setup of > > TYPE_MAIN_VARIANT/TYPE_CANONICAL. Maybe verify TYPE_CANONICAL > > and TYPE_MAIN_VARIANT are also OPAQUE_TYPE. >=20 > It's probably easiest to just test if the TYPE_MODEs match, for OPAQUE_TY= PEs? Thanks for suggestions from both of you! Following your suggestions, I made= a patch which also considers size and alignment information which is mentione= d in the documentation, does it make sense to you?=