From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E48523857038; Mon,  5 Sep 2022 09:29:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E48523857038
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1662370188;
	bh=nXTwK5gLDE+tJqKz30N9NuRSUBIptn9zan1UgGxmqx4=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ZOplfPAIxY9KfVZ7iUztCrKVW+sjKLZ0bJsT0Ss1/ZgyEu1ZbSthpAWzb1KSPdMds
	 F0keJxafILq+QbhSkNwaDHQu/pzy540eH3w+193A/m+PX9cnstpqppZQNxZ8ulgqYm
	 kDF18IHhR58q9QYBq0U+x4eDe/hXG1oXJQ2IqP3I=
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106833] Handle OPAQUE_TYPE in
 gimple_canonical_types_compatible_p
Date: Mon, 05 Sep 2022 09:29:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-checking
X-Bugzilla-Severity: normal
X-Bugzilla-Who: linkw at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106833-4-MFVEGeWNc7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106833-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106833-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106833

--- Comment #5 from Kewen Lin <linkw at gcc dot gnu.org> ---
> > I'm quoting tree.def, emphasis mine:
> >=20
> > /* This is for types that will use MODE_OPAQUE in the back end.  They a=
re
> > meant
> >    to be able to go in a register of some sort but are _EXPLICITLY NOT =
TO BE
> >    CONVERTED_ or operated on like INTEGER_TYPE.  They will have size and
> >    alignment information only.  */
> > DEFTREECODE (OPAQUE_TYPE, "opaque_type", tcc_type, 0)
>=20
> Also the above says "have size and alignment information only" but the
> path you patch will look at TYPE_PRECISION and signedness.  Why, if that
> was necessary, did the TYPE_MODE check not trigger?
>=20

After reading the documentation you posted, I think the patching place is
wrong. The previous TYPE_MODE check passed, as both TYPE_MODEs are E_XOmode=
.=