public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106833] Miss to handle OPAQUE_TYPE specially in verify_type
Date: Fri, 09 Sep 2022 13:18:31 +0000	[thread overview]
Message-ID: <bug-106833-4-NJyUC3HCUz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106833-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106833

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:e230f11e9784eefed316df7dbc5df6ac999841b2

commit r13-2562-ge230f11e9784eefed316df7dbc5df6ac999841b2
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Fri Sep 9 08:17:21 2022 -0500

    Handle OPAQUE_TYPE specially in verify_type [PR106833]

    As PR106833 shows, cv-qualified opaque type can cause ICE
    during LTO.  It exposes that we missd to handle OPAQUE_TYPE
    well in type verification.  As Richi pointed out, also
    assuming that target will always define TYPE_MAIN_VARIANT
    TYPE_CANONICAL for opaque type, this patch is to check
    both are OPAQUE_TYPE_P and their modes are of MODE_OPAQUE
    class.  Besides, it also checks the only available size
    and alignment information.

            PR middle-end/106833

    gcc/ChangeLog:

            * tree.cc (verify_opaque_type): New function.
            (verify_type): Call verify_opaque_type for OPAQUE_TYPE.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr106833.c: New test.

  parent reply	other threads:[~2022-09-09 13:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05  8:01 [Bug middle-end/106833] New: Handle OPAQUE_TYPE in gimple_canonical_types_compatible_p linkw at gcc dot gnu.org
2022-09-05  8:09 ` [Bug middle-end/106833] " linkw at gcc dot gnu.org
2022-09-05  8:25 ` rguenth at gcc dot gnu.org
2022-09-05  8:27 ` rguenth at gcc dot gnu.org
2022-09-05  9:26 ` linkw at gcc dot gnu.org
2022-09-05  9:29 ` linkw at gcc dot gnu.org
2022-09-05  9:58 ` rguenther at suse dot de
2022-09-05 16:25 ` segher at gcc dot gnu.org
2022-09-06  3:40 ` linkw at gcc dot gnu.org
2022-09-06 21:21 ` segher at gcc dot gnu.org
2022-09-07  4:28 ` linkw at gcc dot gnu.org
2022-09-07  4:31 ` [Bug middle-end/106833] Miss to handle OPAQUE_TYPE specially in verify_type linkw at gcc dot gnu.org
2022-09-07 13:08 ` segher at gcc dot gnu.org
2022-09-09 13:18 ` cvs-commit at gcc dot gnu.org [this message]
2022-09-14 12:43 ` linkw at gcc dot gnu.org
2022-09-14 12:53 ` bergner at gcc dot gnu.org
2022-09-14 13:50 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106833-4-NJyUC3HCUz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).