public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/106838] New: Built-in traits have wrong preconditions Date: Mon, 05 Sep 2022 17:06:48 +0000 [thread overview] Message-ID: <bug-106838-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106838 Bug ID: 106838 Summary: Built-in traits have wrong preconditions Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c++ Assignee: unassigned at gcc dot gnu.org Reporter: redi at gcc dot gnu.org Target Milestone: --- According to https://gcc.gnu.org/onlinedocs/gcc/Type-Traits.html the precondition for __has_virtual_destructor is: "Requires: type shall be a complete type, (possibly cv-qualified) void, or an array of unknown bound." This seems to be what the implementation actually requires: union Inc; static_assert( !__has_virtual_destructor(Inc)); struct Inc2; static_assert( !__has_virtual_destructor(Inc2[1]) ); inc.C:2:45: error: invalid use of incomplete type 'union Inc' 2 | static_assert( !__has_virtual_destructor(Inc)); | ^ inc.C:1:7: note: forward declaration of 'union Inc' 1 | union Inc; | ^~~ inc.C:4:49: error: invalid use of incomplete type 'struct Inc2' 4 | static_assert( !__has_virtual_destructor(Inc2[1]) ); | ^ inc.C:3:8: note: forward declaration of 'struct Inc2' 3 | struct Inc2; | ^~~~ However, the precondition for the std::has_virtual_destructor trait is different: "If T is a non-union class type, T shall be a complete type." So std::has_virtual_destructor_v<Inc> and std::has_virtual_destructor_v<Inc2[1]> should both be false. But because the library trait just uses __has_virtual_destructor, those are ill-formed. Should the built-in (and its documentation) be adjusted to match the library's requirements? Clang gives the same errors as GCC. EDG rejects the incomplete union, but allows the array of incomplete type. This suggests that the library trait needs to avoid using the built-in for those types, even if GCC's built-in is changed to support it.
next reply other threads:[~2022-09-05 17:06 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-05 17:06 redi at gcc dot gnu.org [this message] 2022-09-05 17:06 ` [Bug c++/106838] " redi at gcc dot gnu.org 2022-09-05 17:32 ` redi at gcc dot gnu.org 2022-09-05 21:16 ` redi at gcc dot gnu.org 2022-09-05 21:21 ` redi at gcc dot gnu.org 2022-09-06 10:29 ` redi at gcc dot gnu.org 2022-09-06 10:32 ` redi at gcc dot gnu.org 2022-09-06 12:28 ` redi at gcc dot gnu.org 2022-09-06 12:28 ` redi at gcc dot gnu.org 2022-09-08 18:32 ` cvs-commit at gcc dot gnu.org 2022-09-08 18:32 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106838-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).