From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 0AA0238207C6; Thu, 15 Sep 2022 20:37:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0AA0238207C6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1663274233;
	bh=/Px0U24LTjpHDPBLk3KlcIUs3EnFfMJqiSpKdfvu5Zo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=DWF3xH6dYSRiRAVodquG2IpkJegVFzINdQp9va/2FcleQKMYFOehXQ8jes+poMY1a
	 gQ5mJ+8STWZb32+m21zXJLqVFwLbrAT/Rz12D61yrEq7/AijmmrIjTXIiPoLMWT/G6
	 HY0bpAqCwoODx/KB3nbKTd2nQehoAXwDi1/Om2Nc=
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/106857] [10/11/12/13 Regression] ICE in
 gfc_simplify_pack, at fortran/simplify.cc:6438 since
 r12-4278-g74ccca380cde5e79
Date: Thu, 15 Sep 2022 20:37:12 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: anlauf at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: anlauf at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status assigned_to
Message-ID: <bug-106857-4-AEmqBsbYCb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106857-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106857-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106857

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot g=
nu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #1)
> Obvious fix for NULL pointer dereference:
>=20
> diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> index bc178d54891..d5c4fe8443d 100644
> --- a/gcc/fortran/simplify.cc
> +++ b/gcc/fortran/simplify.cc
> @@ -6431,7 +6432,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask,
> gfc_expr *vector)
>        /* Copy only those elements of ARRAY to RESULT whose
>  	 MASK equals .TRUE..  */
>        mask_ctor =3D gfc_constructor_first (mask->value.constructor);
> -      while (mask_ctor)
> +      while (mask_ctor && array_ctor)
>  	{
>  	  if (mask_ctor->expr->value.logical)
>  	    {

This regtests fine.  Taking.=