public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106870] New: ctrl_altering flag is not set correctly
Date: Wed, 07 Sep 2022 11:28:36 +0000	[thread overview]
Message-ID: <bug-106870-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106870

            Bug ID: 106870
           Summary: ctrl_altering flag is not set correctly
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

When trying to add the following verification I run into various issues with
the gimple_ctrl_altering_p flag which stmt_ends_bb_p which sets found_ctrl_stmt
ultimatively relies on for the noreturn case.

diff --git a/gcc/tree-cfg.cc b/gcc/tree-cfg.cc
index bbe08357d6e..a939a11d8bb 100644
--- a/gcc/tree-cfg.cc
+++ b/gcc/tree-cfg.cc
@@ -5708,6 +5709,14 @@ gimple_verify_flow_info (void)
            seen_nondebug_stmt = true;
        }

+      if (!found_ctrl_stmt && EDGE_COUNT (bb->succs) != 1)
+       {
+         error ("basic block %d has no control altering stmt but %d "
+                "outgoing edges",
+                bb->index, EDGE_COUNT (bb->succs));
+         err = 1;
+       }
+
       gsi = gsi_last_nondebug_bb (bb);
       if (gsi_end_p (gsi))
        continue;

             reply	other threads:[~2022-09-07 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 11:28 rguenth at gcc dot gnu.org [this message]
2022-09-07 13:32 ` [Bug middle-end/106870] " rguenth at gcc dot gnu.org
2022-09-08 14:06 ` cvs-commit at gcc dot gnu.org
2022-09-08 14:08 ` rguenth at gcc dot gnu.org
2024-06-21  3:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106870-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).