From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6175A38460A7; Wed, 17 May 2023 18:54:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6175A38460A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684349640; bh=PD1Eu4B/ui9tHK/CiiHk0U1P8urP26X0WDaohQVSEi0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=T9n3Q2cekPrjRA0/loz9Uut1sCr5SPGw6359/mMNSjYJJDRCFvhSomhZIsHCzgJ7T EeoO/XUo9MqrLeWVaqwpAapZqSBx4QumdrX/kA2OrEzEzgD17mYky5CQc6oYr5Tqyx lAjMGuF8G0tZPJwM9+vfQ1GXZtdF8IJBmWOMxeYc= From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/106902] [11/12/13/14 Regression] Program compiled with -O3 -mfma produces different result Date: Wed, 17 May 2023 18:54:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 12.2.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 11.4 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106902 --- Comment #23 from Andrew Pinski --- (In reply to Alexander Monakov from comment #22) > Created attachment 55105 [details] > patch 1/3 >=20 > (In reply to Richard Biener from comment #21) > >=20 > > Sounds reasonable. Though I wouldn't use GENERIC folding but instead > > some folding-like code in c-family/ that for example would get invoked > > by genericization or via the gimplification hook? If we'd add GENERIC > > folding in fold-const.cc or match.pd the chance is that it will pick up > > FMAs "late". >=20 > Agreed, thank you. I'm working on it. The attached patch implements this = via > c_gimplify_expr and passes bootstrap+regtest under 'configure > --with-cpu=3Dznver2' (i.e. with fma available by default). Hmm, seems like this should not be in the C family but the generic part of gimplifier. Because IIRC Fortran has similar rules but IIRC fortran front-e= nd emits PAREN_EXPR a lot more which improves the situtation there ...=