public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/106906] libgomp/env.c: 3 * boolean value assigned to pointer Date: Tue, 13 Sep 2022 17:04:24 +0000 [thread overview] Message-ID: <bug-106906-4-2AZV6lecVU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106906-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106906 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:e11babbfac21163118b69dd25b468ade80dbe8de commit r13-2652-ge11babbfac21163118b69dd25b468ade80dbe8de Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Sep 13 19:00:02 2022 +0200 libgomp: Appease some static analyzers [PR106906] While icv_addr[1] = false; assignments where icv_addr has void * element type is correct and matches how it is used (in those cases the void * pointer is then cast to bool and used that way), there is no reason not to add explicit (void *) casts there which are there already for (void *) true. And, there is in fact even no point in actually doing those stores at all because we set that pointer to NULL a few lines earlier. So, this patch adds the explicit casts and then comments those out to show intent. 2022-09-13 Jakub Jelinek <jakub@redhat.com> PR libgomp/106906 * env.c (get_icv_member_addr): Cast false to void * before assigning it to icv_addr[1], and comment the whole assignment out.
next prev parent reply other threads:[~2022-09-13 17:04 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-12 11:01 [Bug libgomp/106906] New: " dcb314 at hotmail dot com 2022-09-12 11:33 ` [Bug libgomp/106906] " jakub at gcc dot gnu.org 2022-09-13 17:04 ` cvs-commit at gcc dot gnu.org [this message] 2022-09-13 17:06 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106906-4-2AZV6lecVU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).