From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9C30B3856DD6; Tue, 13 Sep 2022 17:04:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C30B3856DD6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1663088664;
	bh=cy9UUgJ96CSLe/Hb8EaOvBwbq+ciZ7FU24icA8WsL/I=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=CpwPEzM4I0UCr6p7uPmS8sIkUHtLpAjk2qhgvtKHZgdv6UUCRJ6phrAXNcALD4eRm
	 cTP0GO7pdL4ep8Bub+WuHZLjBJwFyWh2g9gjRHheD3efErh7D/uniN74+ipR2X9qvy
	 czMjzm4JELju8/hfqdOzfT2/d07UfxNyjWUFQ/BI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/106906] libgomp/env.c: 3 * boolean value assigned to
 pointer
Date: Tue, 13 Sep 2022 17:04:24 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgomp
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106906-4-2AZV6lecVU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106906-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106906-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106906

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e11babbfac21163118b69dd25b468ade80dbe8de

commit r13-2652-ge11babbfac21163118b69dd25b468ade80dbe8de
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Sep 13 19:00:02 2022 +0200

    libgomp: Appease some static analyzers [PR106906]

    While icv_addr[1] =3D false; assignments where icv_addr has void *
    element type is correct and matches how it is used (in those cases
    the void * pointer is then cast to bool and used that way), there is no
    reason not to add explicit (void *) casts there which are there already
    for (void *) true.  And, there is in fact even no point in actually
    doing those stores at all because we set that pointer to NULL a few
    lines earlier.  So, this patch adds the explicit casts and then
    comments those out to show intent.

    2022-09-13  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/106906
            * env.c (get_icv_member_addr): Cast false to void * before
assigning
            it to icv_addr[1], and comment the whole assignment out.=