From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 2CACD3857010; Mon, 12 Sep 2022 11:08:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CACD3857010
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1662980911;
	bh=SwOL8D3aXpF2zuBlbImuKzyHiDAbVW/05r3isxryEMU=;
	h=From:To:Subject:Date:From;
	b=v5h7mbzD9euEEFRYg2TnCvmL2ubTr7E9HDYsQhbGjiUUUo3kuOozS0iV8q8d/wY42
	 B+aqd/nqARUIECJgnpX5xThHgIH3iPIKH5i2fO5hDc+C/g84UD4ytYQtNV3i148izc
	 9mB+Te+/iMnY31Hv2rspTX4EBXgDwRR/UM1tthC0=
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/106907] New: gcc/config/rs6000/rs6000.cc:23155: strange
 expression ?
Date: Mon, 12 Sep 2022 11:08:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dcb314 at hotmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-106907-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106907

            Bug ID: 106907
           Summary: gcc/config/rs6000/rs6000.cc:23155: strange expression
                    ?
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Static analyser cppcheck says:

gcc/config/rs6000/rs6000.cc:23155:16: style: Boolean result is used in bitw=
ise
operation. Clarify expression with parentheses. [clarifyCondition]

Source code is

  fprintf (file, "\t  .amdhsa_system_vgpr_workitem_id\t%i\n",
       (cfun->machine->args.requested & (1 << WORK_ITEM_ID_Z_ARG))
       ? 2
       : cfun->machine->args.requested & (1 << WORK_ITEM_ID_Y_ARG)
       ? 1 : 0);

Maybe better code:

  fprintf (file, "\t  .amdhsa_system_vgpr_workitem_id\t%i\n",
       (cfun->machine->args.requested & (1 << WORK_ITEM_ID_Z_ARG))
       ? 2
       : (cfun->machine->args.requested & (1 << WORK_ITEM_ID_Y_ARG))
       ? 1 : 0);=