public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/106924] Nested class: virtual function returns wrong pointer of covariant type Date: Wed, 14 Sep 2022 10:10:53 +0000 [thread overview] Message-ID: <bug-106924-4-HOwtNMMl76@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106924-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106924 Jonathan Wakely <redi at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Last reconfirmed| |2022-09-14 --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> --- Reduced to remove unnecessary virtual functions that are never used, and fix the printf formats, and make it fail at runtime: extern "C" int printf(const char*, ...); extern "C" void abort(); struct BaseA { virtual ~BaseA(){} }; struct BaseB { virtual ~BaseB(){} }; struct DerivedAB; struct FabForB { virtual BaseA* getPtr()=0; virtual ~FabForB(){} }; struct DerivedAB : BaseB, BaseA { struct ABFabNested : FabForB { virtual DerivedAB* getPtr(); }; }; void print(const DerivedAB* dp, const BaseA* ap, bool nested = false) { } DerivedAB d; DerivedAB* DerivedAB::ABFabNested::getPtr() { DerivedAB* p = &d; printf("TEST fab nested: addr %p base %p\n", p, (BaseA*)p); return p; } struct ABFab : FabForB { virtual DerivedAB* getPtr() { DerivedAB* p = &d; printf("TEST fab: addr %p base %p\n", p, (BaseA*)p); return p; } }; int main() { ABFab fab; DerivedAB::ABFabNested fabNested; BaseA* a1 = fab.getPtr(); BaseA* a2 = static_cast<FabForB&>(fab).getPtr(); printf("TEST addr %p %p\n", a1, a2); a1 = fabNested.getPtr(); a2 = static_cast<FabForB&>(fabNested).getPtr(); printf("TEST nested addr %p %p\n", a1, a2); if (a1 != a2) abort(); } G++ prints: TEST fab: addr 0x404060 base 0x404068 TEST fab: addr 0x404060 base 0x404068 TEST addr 0x404068 0x404068 TEST fab nested: addr 0x404060 base 0x404068 TEST fab nested: addr 0x404060 base 0x404068 TEST nested addr 0x404068 0x404060 Aborted (core dumped) When we call fabNested.getPtr() to get a DerivedAB* and then convert to BaseA* at the call site, the pointer is correctly adjusted to the BaseA base subobject. When we call static_cast<FabForB&>(fabNested).getPtr() to get a BaseA* the covariant return is not adjusted, and the address of the DerivedAB complete object is returned, not its BaseA base subobejct..
next prev parent reply other threads:[~2022-09-14 10:10 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-13 10:07 [Bug c++/106924] New: " aeiken at motortech dot de 2022-09-14 10:10 ` redi at gcc dot gnu.org [this message] 2022-09-14 10:19 ` [Bug c++/106924] " redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106924-4-HOwtNMMl76@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).