From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 199F2385734E; Mon, 10 Oct 2022 19:35:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 199F2385734E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1665430506;
	bh=xUIftw7baRucVy2miACeDITdZswpPKUSCBRk0+rwyoA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=NrzU6vuftT/ijD1dgGvT6YX4MsJqkCbStymlKS0h/siBD37B6bJ1Sj/FRjlJmC97E
	 qiYzf9aocDbuaU8asysD6lZtslOJe1pF0l9WopJj5NHa6dYHgYVinmJLqHLqmH5fQ1
	 Aj4CUEq9m1SPkmPU6dcF7x3M0fQv0r1QoS3R49ks=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106937] [10/11/12/13 Regression] ICE tree check: expected
 identifier_node, have tree_list in pp_tree_identifier, at
 tree-pretty-print.cc:4606 since r10-1214-g1bf32c1141e23074
Date: Mon, 10 Oct 2022 19:35:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106937-4-qPxQhN6LUI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106937-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106937-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106937

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:67efffec943656a509e036cd3c785a5c3d6885e1

commit r13-3202-g67efffec943656a509e036cd3c785a5c3d6885e1
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Sep 29 17:49:32 2022 -0400

    c-family: ICE with [[gnu::nocf_check]] [PR106937]

    When getting the name of an attribute, we ought to use
    get_attribute_name, which handles both [[]] and __attribute__(())
    forms.  Failure to do so may result in an ICE, like here.

    pp_c_attributes_display wasn't able to print the [[]] form of
    attributes, so this patch teaches it to.

    When printing a pointer to function with a standard attribute, the
attribute
    should be printed after the parameter-list.  With this patch we print:

      aka 'void (*)(int) [[gnu::nocf_check]]'

    or, in C++ with noexcept:

      aka 'void (*)(int) noexcept [[gnu::nocf_check]]'

    pp_c_attributes has been unused since its introduction in r56273 so
    this patch removes it.

            PR c++/106937

    gcc/c-family/ChangeLog:

            * c-pretty-print.cc (pp_c_specifier_qualifier_list): Print only=
 GNU
            attributes here.
            (c_pretty_printer::direct_abstract_declarator): Print the stand=
ard
[[]]
            attributes here.
            (pp_c_attributes): Remove.
            (pp_c_attributes_display): Print the [[]] form if appropriate. =
 Use
            get_attribute_name.  Don't print a trailing space when printing=
 the
            [[]] form.
            * c-pretty-print.h (pp_c_attributes): Remove.

    gcc/cp/ChangeLog:

            * error.cc: Include "attribs.h".
            (dump_type_prefix): Print only GNU attributes here.
            (dump_type_suffix): Print standard attributes here.

    gcc/testsuite/ChangeLog:

            * c-c++-common/pointer-to-fn1.c: New test.=