public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug d/106977] [13 regression] d21 dies with SIGBUS on 32-bit Darwin
Date: Thu, 23 Feb 2023 10:51:40 +0000	[thread overview]
Message-ID: <bug-106977-4-XvXgexNgqV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106977-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106977

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to ibuclaw from comment #9)
> (In reply to Iain Sandoe from comment #8)
> > +
> > +/* NODE is a FUNCTION_DECL, VAR_DECL or RECORD_TYPE for the declaration SYM.
> > +   Set flags to reflect visibility that NODE will get in the object file. 
> > */
> > +
> > +void
> > +set_visibility_for_decl (tree node, Dsymbol *sym)
> > 
> > hmmm.. should the call be "set_visibility_for_decl (decl, decl->csym); ?
> > 
> > or should the signature of set_visibility_for_decl() be
> > set_visibility_for_decl (Dsymbol *sym, tree node)?
> > 
> > or maybe I misread the comment....
> I might be unclear, first parameter (NODE) is a tree *_DECL representation
> for the second parameters (SYM) that is the associated front-end symbol.

yeah but the definition of set_visibility_for_decl() is:
+void
+set_visibility_for_decl (tree node, Dsymbol *sym)

which seems to be the opposite order (so if that's intended ... then the
comment definitely needs to distinguish between D nodes and other cases)

  parent reply	other threads:[~2023-02-23 10:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 14:06 [Bug d/106977] New: " ro at gcc dot gnu.org
2022-09-21  7:48 ` [Bug d/106977] " rguenth at gcc dot gnu.org
2022-11-07 14:37 ` ibuclaw at gdcproject dot org
2022-11-07 14:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-11-07 15:34 ` ibuclaw at gdcproject dot org
2022-11-07 15:43 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-02-22 23:58 ` iains at gcc dot gnu.org
2023-02-23  1:20 ` ibuclaw at gcc dot gnu.org
2023-02-23  7:38 ` iains at gcc dot gnu.org
2023-02-23 10:21 ` iains at gcc dot gnu.org
2023-02-23 10:43 ` ibuclaw at gcc dot gnu.org
2023-02-23 10:50 ` ibuclaw at gcc dot gnu.org
2023-02-23 10:51 ` iains at gcc dot gnu.org [this message]
2023-02-23 22:49 ` ibuclaw at gcc dot gnu.org
2023-02-23 23:11 ` ibuclaw at gcc dot gnu.org
2023-02-23 23:29 ` iains at gcc dot gnu.org
2023-02-23 23:33 ` pinskia at gcc dot gnu.org
2023-02-23 23:34 ` iains at gcc dot gnu.org
2023-02-23 23:36 ` iains at gcc dot gnu.org
2023-02-23 23:55 ` pinskia at gcc dot gnu.org
2023-02-24  0:00 ` pinskia at gcc dot gnu.org
2023-02-24  1:13 ` ibuclaw at gcc dot gnu.org
2023-02-24  2:03 ` ibuclaw at gcc dot gnu.org
2023-02-24  2:12 ` ibuclaw at gcc dot gnu.org
2023-02-24  7:52 ` iains at gcc dot gnu.org
2023-02-24  8:20 ` ibuclaw at gcc dot gnu.org
2023-02-24  8:46 ` iains at gcc dot gnu.org
2023-02-24 11:39 ` ibuclaw at gcc dot gnu.org
2023-02-24 17:48 ` iains at gcc dot gnu.org
2023-02-24 18:14 ` iains at gcc dot gnu.org
2023-02-24 18:39 ` ibuclaw at gcc dot gnu.org
2023-02-24 20:07 ` iains at gcc dot gnu.org
2023-04-26  6:56 ` [Bug d/106977] [13/14 " rguenth at gcc dot gnu.org
2023-06-28 18:19 ` cvs-commit at gcc dot gnu.org
2023-06-28 18:52 ` cvs-commit at gcc dot gnu.org
2023-06-28 18:57 ` ibuclaw at gcc dot gnu.org
2023-06-29  7:52 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106977-4-XvXgexNgqV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).