From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 94A0D3858284; Fri, 24 Feb 2023 11:39:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 94A0D3858284
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1677238749;
	bh=CfpeI61lvZ4IsBUI4VbpyJmeQ1shY01TQVUsq2wLG4M=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=xU+d93qk0IiSMdtd2HBOCkqTLvUq26IFLBoagU+ntsK170xrh7ipRbTVh3lMsI0KT
	 rfHfgTRTbOjOTi6ROnSJMc54r0nrdm4MGUN5yxTu0gOIFY02drZC8rGsafCGfcQoun
	 o6UwvrnvUU69bP/a2Hbr3Xa/rPJ6WH3mIPEyajl0=
From: "ibuclaw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug d/106977] [13 regression] d21 dies with SIGBUS on 32-bit Darwin
Date: Fri, 24 Feb 2023 11:39:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: d
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ibuclaw at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: ibuclaw at gdcproject dot org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106977-4-jWpgSCxDFZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106977-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106977-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106977

--- Comment #26 from ibuclaw at gcc dot gnu.org ---
Comparing the D and C++ trees side by side.

At the point of `finish_function` for the ::vis() method, I see the followi=
ng:

D:   type <record_type 0x7ffff6f91888 Visibility cxx-odr-p BLK
C++: type <record_type 0x7ffff700aa80 Visibility cxx-odr-p type_5 DI

When does TYPE_MODE get set, and why is it that value?

Setting watchers in both language compilers...

- C++/D: make_node() sets the memory to E_VOIDmode
- C++/D: entrypoint to compute_record_type() sets BLKmode
- D:     returns early because all fields still have DECL_SIZE =3D null
- C++:   exit to compute_record_type() sets E_DImode=20

In D, this is finish_aggregate_type() which calls compute_record_mode() bef=
ore
calling layout_decl() on all fields.  This was not the=20

Looking at history between 2022/06/10 .. 2022/06/24, I think we have a clear
commit that introduced this wrong code/behaviour - r13-1104.

The loop added in r13-1104 that sets DECL_SIZE on all fields was added after
the call to compute_record_mode.

Looks like this is the mistake, it should have been put before
compute_record_mode.

So then, I think we finally have a fix:

--- a/gcc/d/types.cc
+++ b/gcc/d/types.cc
@@ -615,9 +615,6 @@ finish_aggregate_type (unsigned structsize, unsigned
alignsize, tree type)
   SET_TYPE_ALIGN (type, alignsize * BITS_PER_UNIT);
   TYPE_PACKED (type) =3D (alignsize =3D=3D 1);

-  /* Set the back-end type mode.  */
-  compute_record_mode (type);
-
   /* Layout all fields now the type is complete.  */
   for (tree field =3D TYPE_FIELDS (type); field; field =3D DECL_CHAIN (fie=
ld))
     {
@@ -662,6 +659,9 @@ finish_aggregate_type (unsigned structsize, unsigned
alignsize, tree type)
        }
     }

+  /* Set the back-end type mode after all fields have had their size set. =
 */
+  compute_record_mode (type);
+
   /* Fix up all forward-referenced variants of this aggregate type.  */
   for (tree t =3D TYPE_MAIN_VARIANT (type); t; t =3D TYPE_NEXT_VARIANT (t))
     {=