From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A60D83858439; Fri,  4 Nov 2022 08:31:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A60D83858439
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1667550687;
	bh=iE7aKgq1MF3anCpGuQaVnGn45OF6AWQijKNCvEjpwCY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=CeTpXNl+yaBov0kc/8YaNhzeQbkNRv7ozERcz7Cult7qtw/hoTB1bwa12iQWXY/vi
	 O5Bp33T7ZAwrElMYDoiSw1zgDrmCrVpjUtFau6kFXJFT9KVcAbR/AeBHhcnHjaTrVL
	 LJD61bfjSaAnyaRYvNFPQcvb/NS4nH2Swr8IgiUo=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/106981] [10/11/12 Regression][OpenACC][OpenMP] ICE in
 decompose, at wide-int.h:984 with '#pragma omp/acc atomic capture'
Date: Fri, 04 Nov 2022 08:31:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-invalid-code, openacc, openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106981-4-Y0z8CI7pxQ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106981-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106981-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106981

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:01b894bc8a59691cc1d8dc29936635c8cfb8aed7

commit r11-10359-g01b894bc8a59691cc1d8dc29936635c8cfb8aed7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Sep 24 09:19:26 2022 +0200

    openmp, c: Tighten up c_tree_equal [PR106981]

    This patch changes c_tree_equal to work more like cp_tree_equal, be
    more strict in what it accepts.  The ICE on the first testcase was
    due to INTEGER_CST wi::wide (t1) =3D=3D wi::wide (t2) comparison which
    ICEs if the two constants have different precision, but as the second
    testcase shows, being too lenient in it can also lead to miscompilation
    of valid OpenMP programs where we think certain expression is the same
    even when it isn't and can be guaranteed at runtime to represent differ=
ent
    memory location.  So, the patch looks through only NON_LVALUE_EXPRs
    and for constants as well as casts requires that the types match before
    actually comparing the constant values or recursing on the cast operand=
s.

    2022-09-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/106981
    gcc/c/
            * c-typeck.c (c_tree_equal): Only strip NON_LVALUE_EXPRs at the
            start.  For CONSTANT_CLASS_P or CASE_CONVERT: return false if t1
and
            t2 have different types.
    gcc/testsuite/
            * c-c++-common/gomp/pr106981.c: New test.
    libgomp/
            * testsuite/libgomp.c-c++-common/pr106981.c: New test.

    (cherry picked from commit 3c5bccb608c665ac3f62adb1817c42c845812428)=