public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/106981] [10/11/12/13 Regression][OpenACC][OpenMP] ICE in decompose, at wide-int.h:984 with '#pragma omp/acc atomic capture' Date: Sat, 24 Sep 2022 07:31:32 +0000 [thread overview] Message-ID: <bug-106981-4-aDPMmm4FLa@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106981-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106981 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:3c5bccb608c665ac3f62adb1817c42c845812428 commit r13-2828-g3c5bccb608c665ac3f62adb1817c42c845812428 Author: Jakub Jelinek <jakub@redhat.com> Date: Sat Sep 24 09:19:26 2022 +0200 openmp, c: Tighten up c_tree_equal [PR106981] This patch changes c_tree_equal to work more like cp_tree_equal, be more strict in what it accepts. The ICE on the first testcase was due to INTEGER_CST wi::wide (t1) == wi::wide (t2) comparison which ICEs if the two constants have different precision, but as the second testcase shows, being too lenient in it can also lead to miscompilation of valid OpenMP programs where we think certain expression is the same even when it isn't and can be guaranteed at runtime to represent different memory location. So, the patch looks through only NON_LVALUE_EXPRs and for constants as well as casts requires that the types match before actually comparing the constant values or recursing on the cast operands. 2022-09-24 Jakub Jelinek <jakub@redhat.com> PR c/106981 gcc/c/ * c-typeck.cc (c_tree_equal): Only strip NON_LVALUE_EXPRs at the start. For CONSTANT_CLASS_P or CASE_CONVERT: return false if t1 and t2 have different types. gcc/testsuite/ * c-c++-common/gomp/pr106981.c: New test. libgomp/ * testsuite/libgomp.c-c++-common/pr106981.c: New test.
next prev parent reply other threads:[~2022-09-24 7:31 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-20 16:40 [Bug c/106981] New: [OpenMP] ICE in decompose, at wide-int.h:984 with '#pragma acc " burnus at gcc dot gnu.org 2022-09-20 16:46 ` [Bug c/106981] [OpenACC][OpenMP] ICE in decompose, at wide-int.h:984 with '#pragma omp/acc " burnus at gcc dot gnu.org 2022-09-21 7:49 ` [Bug c/106981] [10/11/12/13 Regression][OpenACC][OpenMP] " rguenth at gcc dot gnu.org 2022-09-21 13:20 ` burnus at gcc dot gnu.org 2022-09-21 13:36 ` jakub at gcc dot gnu.org 2022-09-21 14:10 ` burnus at gcc dot gnu.org 2022-09-23 8:59 ` jakub at gcc dot gnu.org 2022-09-23 9:08 ` burnus at gcc dot gnu.org 2022-09-23 9:15 ` jakub at gcc dot gnu.org 2022-09-23 9:44 ` jakub at gcc dot gnu.org 2022-09-24 7:31 ` cvs-commit at gcc dot gnu.org [this message] 2022-10-18 8:43 ` [Bug c/106981] [10/11/12 " rguenth at gcc dot gnu.org 2022-11-03 0:23 ` cvs-commit at gcc dot gnu.org 2022-11-04 8:31 ` cvs-commit at gcc dot gnu.org 2022-11-04 11:01 ` [Bug c/106981] [10 " jakub at gcc dot gnu.org 2023-05-03 15:19 ` cvs-commit at gcc dot gnu.org 2023-05-04 7:19 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106981-4-aDPMmm4FLa@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).