[Bug middle-end/106982] New: [OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[Bug middle-end/106982] New: [OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

            Bug ID: 106982
           Summary: [OpenACC] ICE incorrect sharing of tree nodes with
                    nested reduction / .GOACC_REDUCTION
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, openacc
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: tschwinge at gcc dot gnu.org
  Target Milestone: ---

ICE with gcc/g++ -fopenacc:

share10.i:6:9: error: incorrect sharing of tree nodes
    6 | #pragma acc loop worker reduction(*:reduced)
      |         ^~~
MEM <double[5]> [(double *)&reduced]
MEM <double[5]> [(double *)&reduced] = .GOACC_REDUCTION (SETUP, 0, MEM
<double[5]> [(double *)&reduced], -1, 73, 0);
share10.i:6:9: error: incorrect sharing of tree nodes

----------- Failing code is -------------
int test1(double *c)
{
    double reduced[5];
#pragma acc parallel loop gang private(reduced)
    for (int x = 0; x < 5; ++x)
#pragma acc loop worker reduction(*:reduced)
      for (int y = 0; y < 5; ++y) { }
}

[Bug middle-end/106982] [10/11/12/13 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5

[Bug middle-end/106982] [10/11/12/13 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Submitted patch:
  https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602138.html

[Bug middle-end/106982] [10/11/12/13 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:d3df98807b58df186061ad52ff87cc09ba593e9b

commit r13-2868-gd3df98807b58df186061ad52ff87cc09ba593e9b
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon Sep 26 12:45:28 2022 +0200

    OpenACC: Fix reduction tree-sharing issue [PR106982]

    The tree for var == incoming == outgound was
    'MEM <double[5]> [(double *)&reduced]' which caused the ICE
    "incorrect sharing of tree nodes".

            PR middle-end/106982

    gcc/ChangeLog:

            * omp-low.cc (lower_oacc_reductions): Add some unshare_expr.

    gcc/testsuite/ChangeLog:

            * c-c++-common/goacc/reduction-7.c: New test.
            * c-c++-common/goacc/reduction-8.c: New test.

[Bug middle-end/106982] [10/11/12/13 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:afea1ae84f0c3e64137289c44c756195babe1845

commit r12-8793-gafea1ae84f0c3e64137289c44c756195babe1845
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon Sep 26 12:45:28 2022 +0200

    OpenACC: Fix reduction tree-sharing issue [PR106982]

    The tree for var == incoming == outgound was
    'MEM <double[5]> [(double *)&reduced]' which caused the ICE
    "incorrect sharing of tree nodes".

            PR middle-end/106982

    gcc/ChangeLog:

            * omp-low.cc (lower_oacc_reductions): Add some unshare_expr.

    gcc/testsuite/ChangeLog:

            * c-c++-common/goacc/reduction-7.c: New test.
            * c-c++-common/goacc/reduction-8.c: New test.

    (cherry picked from commit d3df98807b58df186061ad52ff87cc09ba593e9b)

[Bug middle-end/106982] [10/11 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|12.2.1                      |12.2.0
      Known to work|                            |12.2.1, 13.0
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-12-22
     Ever confirmed|0                           |1
            Summary|[10/11/12/13                |[10/11 Regression][OpenACC]
                   |Regression][OpenACC] ICE    |ICE incorrect sharing of
                   |incorrect sharing of tree   |tree nodes with nested
                   |nodes with nested reduction |reduction /
                   |/ .GOACC_REDUCTION          |.GOACC_REDUCTION
           Priority|P3                          |P2

[Bug middle-end/106982] [10/11 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |burnus at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug middle-end/106982] [11 Regression][OpenACC] ICE incorrect sharing of tree nodes with nested reduction / .GOACC_REDUCTION

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.