public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/106988] subscripting a string literal is not an integer constant expression but __builtin_strlen is
Date: Thu, 22 Sep 2022 16:12:19 +0000	[thread overview]
Message-ID: <bug-106988-4-KeMIKshK6T@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106988-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106988

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DUPLICATE                   |---
             Status|RESOLVED                    |UNCONFIRMED
           Keywords|diagnostic                  |rejects-valid

--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
After experimenting with this some more I think the decision to reject this and
the other similar requests should be reconsidered.  GCC accepts many equivalent
nonconstant expressions in contexts where they are required (see below). 
Rejecting the simplest of them seems arbitrary and is (as is evident from the
duplicate requests) unhelpful to C programmers and surprising those used to the
C++ behavior.

$ cat a.c && gcc -S -Wall -Wpedantic a.c
#include <string.h>

_Static_assert (memcmp ("", "", 1) == 0, "");  // okay in C mode only
_Static_assert (memchr ("", 0, 1) != 0, "");   // okay in C mode only
_Static_assert (strlen ("") == 0, "");         // okay in C and C++
_Static_assert (strcmp ("", "") == 0, "");     // okay in C and C++
_Static_assert ("" == "", "");                 // okay in C and C++

_Static_assert (*"" == 0, "");                 // error in C only

a.c:3:36: warning: expression in static assertion is not an integer constant
expression [-Wpedantic]
    3 | _Static_assert (memcmp ("", "", 1) == 0, "");  // okay in C mode only
      |                 ~~~~~~~~~~~~~~~~~~~^~~~
a.c:4:35: warning: expression in static assertion is not an integer constant
expression [-Wpedantic]
    4 | _Static_assert (memchr ("", 0, 1) != 0, "");   // okay in C mode only
      |                 ~~~~~~~~~~~~~~~~~~^~~~
a.c:5:29: warning: expression in static assertion is not an integer constant
expression [-Wpedantic]
    5 | _Static_assert (strlen ("") == 0, "");         // okay in C and C++
      |                 ~~~~~~~~~~~~^~~~
a.c:6:33: warning: expression in static assertion is not an integer constant
expression [-Wpedantic]
    6 | _Static_assert (strcmp ("", "") == 0, "");     // okay in C and C++
      |                 ~~~~~~~~~~~~~~~~^~~~
a.c:7:20: warning: comparison with string literal results in unspecified
behavior [-Waddress]
    7 | _Static_assert ("" == "", "");                 // okay in C and C++
      |                    ^~
a.c:7:20: warning: expression in static assertion is not an integer constant
expression [-Wpedantic]
    7 | _Static_assert ("" == "", "");                 // okay in C and C++
      |                 ~~~^~~~~
a.c:9:21: error: expression in static assertion is not constant
    9 | _Static_assert (*"" == 0, "");                 // error in C only
      |                 ~~~~^~~~

      parent reply	other threads:[~2022-09-22 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 20:27 [Bug c/106988] New: " msebor at gcc dot gnu.org
2022-09-21  0:57 ` [Bug c/106988] " pinskia at gcc dot gnu.org
2022-09-22 16:12 ` msebor at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106988-4-KeMIKshK6T@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).