public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107000] ICE in gfc_real2complex, at fortran/arith.cc:2243
Date: Mon, 26 Sep 2022 21:37:57 +0000 [thread overview]
Message-ID: <bug-107000-4-NimGx88XKk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107000-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107000
--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Sep 26, 2022 at 08:38:56PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107000
>
> --- Comment #5 from anlauf at gcc dot gnu.org ---
> (In reply to kargl from comment #4)
> > I think we need to expand the checking in array.cc
> >
> > /* Convert components of an array constructor to the type in ts. */
> >
> > static match
> > walk_array_constructor (gfc_typespec *ts, gfc_constructor_base head)
> >
> > I haven't had time to look deeper, but this function should be comparing
> > the typespecs of REAL and -'1' or +'1'. That should fail. I suspect that
> > the EXPR_OP of type_expr is allowing the array constructor walk to succeed.
>
> You mean sth. like:
>
> diff --git a/gcc/fortran/array.cc b/gcc/fortran/array.cc
> index bbdb5b392fc..78a15917cec 100644
> --- a/gcc/fortran/array.cc
> +++ b/gcc/fortran/array.cc
> @@ -1213,7 +1213,7 @@ walk_array_constructor (gfc_typespec *ts,
> gfc_constructor_base head)
> return m;
> }
> else if (!gfc_convert_type_warn (e, ts, 1, 1, true)
> - && e->ts.type != BT_UNKNOWN)
> + && (e->ts.type != BT_UNKNOWN || e->expr_type == EXPR_OP))
> return MATCH_ERROR;
> }
> return MATCH_YES;
>
> in addition to the fix from comment#2? This works and regtests ok.
>
Yes, that would work! I was thinking of something more complex
such as looking at the types of the operand(s), but simplification
probably handles +1 and -1 correctly and punts on +'1' and -'1'.
next prev parent reply other threads:[~2022-09-26 21:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 17:33 [Bug fortran/107000] New: " gscfq@t-online.de
2022-09-21 17:34 ` [Bug fortran/107000] " gscfq@t-online.de
2022-09-21 18:58 ` anlauf at gcc dot gnu.org
2022-09-21 19:44 ` anlauf at gcc dot gnu.org
2022-09-24 16:30 ` kargl at gcc dot gnu.org
2022-09-26 20:38 ` anlauf at gcc dot gnu.org
2022-09-26 21:37 ` sgk at troutmask dot apl.washington.edu [this message]
2022-09-27 19:32 ` anlauf at gcc dot gnu.org
2022-09-28 18:22 ` kargl at gcc dot gnu.org
2022-09-28 18:55 ` kargl at gcc dot gnu.org
2022-09-29 19:57 ` anlauf at gcc dot gnu.org
2022-09-29 20:10 ` sgk at troutmask dot apl.washington.edu
2022-09-29 21:13 ` sgk at troutmask dot apl.washington.edu
2022-09-30 12:45 ` mikael at gcc dot gnu.org
2022-09-30 19:46 ` anlauf at gcc dot gnu.org
2022-09-30 20:26 ` sgk at troutmask dot apl.washington.edu
2022-10-02 20:05 ` anlauf at gcc dot gnu.org
2022-10-02 20:58 ` anlauf at gcc dot gnu.org
2022-10-03 10:05 ` mikael at gcc dot gnu.org
2022-10-03 10:14 ` mikael at gcc dot gnu.org
2022-10-03 19:36 ` anlauf at gcc dot gnu.org
2022-10-04 21:20 ` anlauf at gcc dot gnu.org
2022-10-05 16:10 ` sgk at troutmask dot apl.washington.edu
2022-10-05 21:20 ` anlauf at gcc dot gnu.org
2022-10-08 20:27 ` cvs-commit at gcc dot gnu.org
2023-05-02 19:11 ` anlauf at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107000-4-NimGx88XKk@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).