From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D836E385842B; Tue, 28 Mar 2023 14:24:49 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D836E385842B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1680013489;
	bh=9DgCfhccdBR8q8sBKzlzgFsUOmpZk49YHZz1rNdDtsU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=FsG8znTfjLnC0K3zIZhIOoqHNhPdVoIgcYKjfqImioMbjxMjFjo/i8H9kn7POf/ii
	 cypsu+oiq808+qu6g50M1MAkKqK9BHKgNH64CVFLckThvwUzyv8DV5R8ojxtnt3KmR
	 28q8IhHLQPTdWOb64H8jVMB+a5ZMZKu/Fcy9AsWo=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/107002] [13 Regression] ICE in column_range, at
 diagnostic-show-locus.cc:2236 since r13-2386-gbedfca647a9e9c1a
Date: Tue, 28 Mar 2023 14:24:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: diagnostic, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-107002-4-lodaxsAew0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107002-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107002-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107002

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
David, any progress here?
Should the diagnostic callers be more careful when passing multiple fixit
locations to make sure they don't overlap (I think in this case they are ev=
en
the exact same location), or should diagnostic-show-locus.cc recover from i=
t?
Given the same location for both, they are equal:
(gdb) p last_correction->m_affected_bytes
$34 =3D {start =3D 1, finish =3D 4}
(gdb) p affected_bytes
$35 =3D {start =3D 1, finish =3D 4}
and so trying to create a column range for finish + 1 of the former to star=
t -
1
of the latter is invalid.=