public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "drepper.fsp+rhbz at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/107009] New: massive unnecessary code blowup in vectorizer Date: Thu, 22 Sep 2022 18:49:10 +0000 [thread overview] Message-ID: <bug-107009-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107009 Bug ID: 107009 Summary: massive unnecessary code blowup in vectorizer Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: drepper.fsp+rhbz at gmail dot com Target Milestone: --- Given an annotated saxpy function: #include <cstdlib> void saxpy(size_t n, float* __restrict res, float a, const float* __restrict x, const float* __restrict y) { if (n == 0 || n % 8 != 0) __builtin_unreachable(); res = (float*)__builtin_assume_aligned(res, 32); x = (const float*) __builtin_assume_aligned(x, 32); y = (const float*) __builtin_assume_aligned(y, 32); for (size_t i = 0; i < n; ++i) res[i] = a * x[i] + y[i]; } Compiling this with the gcc 12.2.1 version from Fedora 36 leads to the expected, guided result (although the shrq isn't necessary…) with -O3: _Z5saxpymPffPKfS1_: .cfi_startproc shrq $3, %rdi vbroadcastss %xmm0, %ymm0 xorl %eax, %eax salq $5, %rdi .p2align 4 .p2align 3 .L2: vmovaps (%rdx,%rax), %ymm1 vfmadd213ps (%rcx,%rax), %ymm0, %ymm1 vmovaps %ymm1, (%rsi,%rax) addq $32, %rax cmpq %rdi, %rax jne .L2 vzeroupper ret The the current trunk gcc the result is massively bigger and given the guidance in the sources none of the extra code is necessary. _Z5saxpymPffPKfS1_: .LFB22: .cfi_startproc movq %rdi, %r8 movq %rdx, %rdi movq %rcx, %rdx leaq -1(%r8), %rax cmpq $6, %rax jbe .L7 movq %r8, %rcx vbroadcastss %xmm0, %ymm2 xorl %eax, %eax shrq $3, %rcx salq $5, %rcx .p2align 4 .p2align 3 .L3: vmovaps (%rdi,%rax), %ymm1 vfmadd213ps (%rdx,%rax), %ymm2, %ymm1 vmovaps %ymm1, (%rsi,%rax) addq $32, %rax cmpq %rcx, %rax jne .L3 movq %r8, %rax andq $-8, %rax testb $7, %r8b je .L18 vzeroupper .L2: movq %r8, %rcx subq %rax, %rcx leaq -1(%rcx), %r9 cmpq $2, %r9 jbe .L5 vmovaps (%rdx,%rax,4), %xmm3 vshufps $0, %xmm0, %xmm0, %xmm1 movq %rcx, %r9 vfmadd132ps (%rdi,%rax,4), %xmm3, %xmm1 andq $-4, %r9 vmovaps %xmm1, (%rsi,%rax,4) addq %r9, %rax andl $3, %ecx je .L16 .L5: vmovss (%rdi,%rax,4), %xmm1 leaq 0(,%rax,4), %rcx leaq 1(%rax), %r9 vfmadd213ss (%rdx,%rax,4), %xmm0, %xmm1 vmovss %xmm1, (%rsi,%rcx) cmpq %r8, %r9 jnb .L16 vmovss 4(%rdi,%rcx), %xmm1 addq $2, %rax vfmadd213ss 4(%rdx,%rcx), %xmm0, %xmm1 vmovss %xmm1, 4(%rsi,%rcx) cmpq %r8, %rax jnb .L16 vmovss 8(%rdx,%rcx), %xmm4 vfmadd132ss 8(%rdi,%rcx), %xmm4, %xmm0 vmovss %xmm0, 8(%rsi,%rcx) .L16: ret .p2align 4 .p2align 3 .L18: vzeroupper ret .p2align 4 .p2align 3 .L7: xorl %eax, %eax jmp .L2
next reply other threads:[~2022-09-22 18:49 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-22 18:49 drepper.fsp+rhbz at gmail dot com [this message] 2022-09-22 19:00 ` [Bug tree-optimization/107009] [13 Regression] " mpolacek at gcc dot gnu.org 2022-09-22 20:03 ` aldyh at gcc dot gnu.org 2022-09-23 6:43 ` rguenth at gcc dot gnu.org 2022-09-23 13:57 ` aldyh at gcc dot gnu.org 2022-09-23 17:56 ` aldyh at gcc dot gnu.org 2022-09-23 17:57 ` aldyh at gcc dot gnu.org 2022-09-23 17:57 ` aldyh at gcc dot gnu.org 2022-09-26 14:42 ` cvs-commit at gcc dot gnu.org 2022-09-26 14:43 ` aldyh at gcc dot gnu.org 2022-09-26 17:25 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107009-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).