public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tneumann at users dot sourceforge.net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target
Date: Mon, 26 Sep 2022 05:44:47 +0000	[thread overview]
Message-ID: <bug-107026-4-TQuk38v9hJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107026-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

--- Comment #6 from Thomas Neumann <tneumann at users dot sourceforge.net> ---
I have a patch ready, I am waiting for approval:

https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602130.html

When using the atomic fast path deregistering can fail during
program shutdown if the lookup structures are already destroyed.
The assert in __deregister_frame_info_bases takes that into
account. In the non-fast-path case however is not aware of
program shutdown, which caused a compiler error on such platforms.
We fix that by introducing a constant for in_shutdown in
non-fast-path builds.

libgcc/ChangeLog:
        * unwind-dw2-fde.c: Introduce a constant for in_shutdown
        for the non-fast-path case.
---
 libgcc/unwind-dw2-fde.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c
index d237179f4ea..0bcd5061d76 100644
--- a/libgcc/unwind-dw2-fde.c
+++ b/libgcc/unwind-dw2-fde.c
@@ -67,6 +67,8 @@ static void
 init_object (struct object *ob);

 #else
+/* Without fast path frame deregistration must always succeed.  */
+static const int in_shutdown = 0;

 /* The unseen_objects list contains objects that have been registered
    but not yet categorized in any way.  The seen_objects list has had
-- 
2.34.1

  parent reply	other threads:[~2022-09-26  5:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24 17:08 [Bug libgcc/107026] New: " unlvsur at live dot com
2022-09-24 17:09 ` [Bug libgcc/107026] " unlvsur at live dot com
2022-09-24 19:07 ` [Bug libgcc/107026] [13 Regression] " pinskia at gcc dot gnu.org
2022-09-25  6:06 ` unlvsur at live dot com
2022-09-25 23:21 ` tnfchris at gcc dot gnu.org
2022-09-25 23:23 ` tnfchris at gcc dot gnu.org
2022-09-26  5:44 ` tneumann at users dot sourceforge.net [this message]
2022-09-26  7:48 ` marxin at gcc dot gnu.org
2022-09-26 13:57 ` tschwinge at gcc dot gnu.org
2022-09-26 14:00 ` tneumann at users dot sourceforge.net
2022-09-27  9:17 ` tschwinge at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107026-4-TQuk38v9hJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).