From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9D450385AC34; Thu, 29 Sep 2022 14:05:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D450385AC34
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1664460309;
	bh=38yC3A/+6iVYjrTAQNPKf1ZtDEBZN2Z6rucCBLQ4rjA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=rYVpyN7kkQp4O1I/bswFXW1vyE7S5iuzPSNwjOlng+i7TGIi3r3+/6iLY+SRJpCpg
	 +Dvb9PfY+icgc3KYn17tONGVTTDwkvq7yPqgpkI0mfdcK2xx6Reeh2bF2akVBbZLtn
	 +lMcfiYYs6rzsHnV0Mcmww7Kap0Rrw9aMtR03tnQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/107028] [13 Regression][OpenACC] ICE in
 install_var_field, at omp-low.cc:797
Date: Thu, 29 Sep 2022 14:05:08 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code, openacc
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jules at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107028-4-LGrF2gx9Ea@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107028-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107028-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107028

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Julian Brown <jules@gcc.gnu.org>:

https://gcc.gnu.org/g:8ace67ddb97698709a622b2f8ba2718524aa5eeb

commit r13-2957-g8ace67ddb97698709a622b2f8ba2718524aa5eeb
Author: Julian Brown <julian@codesourcery.com>
Date:   Tue Sep 27 17:39:59 2022 +0000

    OpenACC: whole struct vs. component mappings (PR107028)

    This patch fixes an ICE when both a complete struct variable and
    components of that struct are mapped on the same directive for OpenACC,
    using a modified version of the scheme used for OpenMP in the following
    patch:

      https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601558.html

    A new function has been added to make sure that the mapping kinds of
    the whole struct and the member access are compatible -- conservatively,
    so as not to copy more to/from the device than the user expects.

    This version of the patch uses a different method to detect duplicate
    clauses for OpenACC in oacc_resolve_clause_dependencies, and removes
    the now-redundant check in omp_accumulate_sibling_lists.  (The latter
    check would no longer trigger when we map the whole struct on the same
    directive because the component-mapping clauses are now deleted before
    the check is executed.)

    2022-09-28  Julian Brown  <julian@codesourcery.com>

    gcc/
            PR middle-end/107028
            * gimplify.cc (omp_check_mapping_compatibility,
            oacc_resolve_clause_dependencies): New functions.
            (omp_accumulate_sibling_list): Remove redundant duplicate clause
            detection for OpenACC.
            (build_struct_sibling_lists): Skip deleted groups.  Don't build
sibling
            list for struct variables that are fully mapped on the same
directive
            for OpenACC.
            (gimplify_scan_omp_clauses): Call oacc_resolve_clause_dependenc=
ies.

    gcc/testsuite/
            PR middle-end/107028
            * c-c++-common/goacc/struct-component-kind-1.c: New test.
            * g++.dg/goacc/pr107028-1.C: New test.
            * g++.dg/goacc/pr107028-2.C: New test.
            * gfortran.dg/goacc/mapping-tests-5.f90: New test.=