public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/107031] endfile truncates file at wrong position
Date: Tue, 26 Mar 2024 01:51:47 +0000	[thread overview]
Message-ID: <bug-107031-4-SPLUGHAKrE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107031-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107031

--- Comment #9 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
The following trivial patch changes gfortran behavior and regression tests Ok
on x86_64.

I will see if I can come up with a test case to catch this.

diff --git a/libgfortran/io/file_pos.c b/libgfortran/io/file_pos.c
index 2bc05b293f8..d169961f997 100644
--- a/libgfortran/io/file_pos.c
+++ b/libgfortran/io/file_pos.c
@@ -352,7 +352,6 @@ st_endfile (st_parameter_filepos *fpp)
          dtp.common = fpp->common;
          memset (&dtp.u.p, 0, sizeof (dtp.u.p));
          dtp.u.p.current_unit = u;
-         next_record (&dtp, 1);
        }

       unit_truncate (u, stell (u->s), &fpp->common);

  parent reply	other threads:[~2024-03-26  1:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25  6:34 [Bug fortran/107031] New: " kishore96 at gmail dot com
2022-09-25 19:21 ` [Bug libfortran/107031] " anlauf at gcc dot gnu.org
2022-09-25 19:46 ` kargl at gcc dot gnu.org
2022-09-25 20:07 ` anlauf at gcc dot gnu.org
2022-09-25 20:56 ` kargl at gcc dot gnu.org
2022-09-26  0:18 ` sgk at troutmask dot apl.washington.edu
2022-09-26 14:33 ` kargl at gcc dot gnu.org
2024-03-26  0:13 ` urbanjost at comcast dot net
2024-03-26  0:38 ` jvdelisle at gcc dot gnu.org
2024-03-26  1:51 ` jvdelisle at gcc dot gnu.org [this message]
2024-03-27  0:17 ` cvs-commit at gcc dot gnu.org
2024-04-10  2:41 ` jvdelisle at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107031-4-SPLUGHAKrE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).