public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "absoler at smail dot nju.edu.cn" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/107051] redundant loads when copying a union
Date: Wed, 27 Mar 2024 00:21:38 +0000 [thread overview]
Message-ID: <bug-107051-4-CIw7RwfDVb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107051-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107051
--- Comment #2 from absoler at smail dot nju.edu.cn ---
(In reply to Richard Biener from comment #1)
> With -O2 I see
>
> func_1:
> .LFB0:
> .cfi_startproc
> movl e(%rip), %eax
> testl %eax, %eax
> je .L2
> .L3:
> jmp .L3
> .p2align 4,,10
> .p2align 3
> .L2:
> movq g_284+8(%rip), %rax
> movq %rax, g_284(%rip)
> ret
>
> note that with -O1 we retain
>
> c = g_284[1];
> c$f0_3 = g_284[1].f0;
> c.f0 = c$f0_3;
> g_284[0] = c;
>
> after GIMPLE optimization which possibly explains this compared to
>
> c = g_284[1];
> g_284[0] = c;
>
> with -O2.
for gcc-13.2.0 -O2, it seems still forget to remove the load for this reduced
case:
```
union U0 {
short f1;
int f2;
};
union U0 g1, g2;
volatile int flag;
void func_1() {
union U0 d[1] = {{.f1 = 1}};
for (; flag;)
;
d[0] = g2;
g1 = d[0];
}
```
```
func_1:
.LFB0:
.cfi_startproc
.p2align 4,,10
.p2align 3
.L2:
movl flag(%rip), %eax
testl %eax, %eax
jne .L2
movl g2(%rip), %eax
movw g2(%rip), %ax
movl %eax, g1(%rip)
ret
.cfi_endproc
```
prev parent reply other threads:[~2024-03-27 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:25 [Bug rtl-optimization/107051] New: " absoler at smail dot nju.edu.cn
2022-09-27 13:18 ` [Bug rtl-optimization/107051] " rguenth at gcc dot gnu.org
2024-03-27 0:21 ` absoler at smail dot nju.edu.cn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107051-4-CIw7RwfDVb@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).