public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107075] ICE in get, at cgraph.h:461
Date: Thu, 06 Oct 2022 18:02:21 +0000	[thread overview]
Message-ID: <bug-107075-4-iVRJdyp3Bv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107075-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107075

--- Comment #5 from anlauf at gcc dot gnu.org ---
There is a check in expr.cc:2623 that is reached if one changes the
testcase to a subroutine, but not if it is a program:

4615          if (!attr.save && rvalue->expr_type == EXPR_VARIABLE
4616              && rvalue->symtree->n.sym->ns->proc_name
4617              &&
rvalue->symtree->n.sym->ns->proc_name->attr.is_main_program)
4618            {
4619              rvalue->symtree->n.sym->ns->proc_name->attr.save =
SAVE_IMPLICIT;
4620              attr.save = SAVE_IMPLICIT;
4621            }
4622
4623          if (!attr.save)
4624            {
4625              gfc_error ("Pointer initialization target at %L "
4626                         "must have the SAVE attribute", &rvalue->where);
4627              return false;
4628            }

I think the first check tries to fake that the target has the right
attributes in a main program (implicit save) while it hasn't.
If we fix the attributes of variables in the main program, the above
check should be revisited.

  parent reply	other threads:[~2022-10-06 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 17:36 [Bug fortran/107075] New: " gscfq@t-online.de
2022-09-28 20:13 ` [Bug fortran/107075] " anlauf at gcc dot gnu.org
2022-09-29  8:17 ` rguenth at gcc dot gnu.org
2022-09-29  9:05 ` mikael at gcc dot gnu.org
2022-09-29 21:16 ` anlauf at gcc dot gnu.org
2022-10-06 18:02 ` anlauf at gcc dot gnu.org [this message]
2022-10-06 19:19 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107075-4-iVRJdyp3Bv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).