public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kloczko.tomasz at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/107078] LTO is causing that firebird build is core dumping
Date: Thu, 29 Sep 2022 10:52:03 +0000	[thread overview]
Message-ID: <bug-107078-4-87Btnvii96@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107078-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107078

--- Comment #5 from Tomasz Kłoczko <kloczko.tomasz at gmail dot com> ---
FWD of the firebird developer from
https://github.com/FirebirdSQL/firebird/issues/7308#issuecomment-1262043660

"Firebird (that code left from interbase times) traditionally zeroes
memory when allocating a lot of internal data structures using function
like calloc(). When moving from C to C++ it was wrapped into operator
new of some base class in order to avoid type casts, be able to use
ctors and a lot of other c++ features. 20 years ago it was fine. Some
years ago an optimization removing any data initalization in new (data
returned by it is not initialized according to standard). By itself it
did not affect the code - our calloc() is placed into separate file,
it's not inline. But together with cross-file optimization... we get
what you've seen.

Certainly correct fix is to move memory initialization into ctor - but
that was not done yet.

May be there some more issues with LTO, I did not learn it deeper."

  parent reply	other threads:[~2022-09-29 10:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 21:51 [Bug lto/107078] New: " kloczko.tomasz at gmail dot com
2022-09-28 22:06 ` [Bug lto/107078] " pinskia at gcc dot gnu.org
2022-09-28 22:08 ` pinskia at gcc dot gnu.org
2022-09-29  8:20 ` rguenth at gcc dot gnu.org
2022-09-29 10:20 ` marxin at gcc dot gnu.org
2022-09-29 10:52 ` kloczko.tomasz at gmail dot com [this message]
2022-09-29 11:00 ` pinskia at gcc dot gnu.org
2022-09-29 11:01 ` jakub at gcc dot gnu.org
2022-09-29 11:04 ` kloczko.tomasz at gmail dot com
2022-09-29 11:09 ` kloczko.tomasz at gmail dot com
2022-09-29 11:21 ` kloczko.tomasz at gmail dot com
2022-09-29 11:24 ` kloczko.tomasz at gmail dot com
2022-11-01 15:00 ` kloczko.tomasz at gmail dot com
2022-11-10 14:17 ` marxin at gcc dot gnu.org
2022-12-02 13:38 ` marxin at gcc dot gnu.org
2022-12-02 16:53 ` kloczko.tomasz at gmail dot com
2022-12-02 18:27 ` marxin at gcc dot gnu.org
2022-12-02 18:53 ` kloczko.tomasz at gmail dot com
2022-12-02 19:04 ` marxin at gcc dot gnu.org
2022-12-03 10:08 ` sam at gentoo dot org
2022-12-05  9:56 ` marxin at gcc dot gnu.org
2022-12-05 12:23 ` kloczko.tomasz at gmail dot com
2022-12-05 12:27 ` sam at gentoo dot org
2022-12-05 12:32 ` marxin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107078-4-87Btnvii96@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).