From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 699E73858D1E; Fri, 30 Sep 2022 17:53:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 699E73858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1664560436; bh=Xzm05BCA2odEYZAk2lkRkhLx1ndO6HSzMWKI9mcVCGY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=n7LiGZ9YKPjypJsFxAdewG+aofzykElNc5SgIZzFa1621QGX0bas639zkEGUX95D8 Nt3Stm9Vpuu5VRmMJNQSrgw/t3cFep299Aa/UlkZpw6dmBPv80zi6i39iImD3N8OHV ksblHcVqut725pUuJQyZSHzRihSC6ua3hx2xclS4= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/107080] ICE in verify_symtab_nodes using _Float64x with long double Date: Fri, 30 Sep 2022 17:53:56 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: ABI, assemble-failure, ice-checking, ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107080 --- Comment #5 from CVS Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:e564021e4c225420cd8986e9a7a42efe741f92d1 commit r13-2993-ge564021e4c225420cd8986e9a7a42efe741f92d1 Author: Jakub Jelinek Date: Fri Sep 30 19:52:49 2022 +0200 aarch64: Fix C++ ICEs with _Float16 and __fp16 [PR107080] On Fri, Sep 30, 2022 at 09:54:49AM -0400, Jason Merrill wrote: > > Note, there is one further problem on aarch64/arm, types with HFmode > > (_Float16 and __fp16) are there mangled as Dh (which is standard > > Itanium mangling: > > ::=3D Dh # IEEE 754r half-precision floating poin= t (16 bits) > > ::=3D DF _ # ISO/IEC TS 18661 binary flo= ating point type _FloatN (N bits) > > so in theory is also ok, but DF16_ is more specific. Should we just > > change Dh to DF16_ in those backends, or should __fp16 there be distinct > > type from _Float16 where __fp16 would mangle Dh and _Float16 DF16_ ? > > You argued for keeping __float128 separate from _Float128, does the s= ame > argument not apply to this case? Actually, they already were distinct types that just mangled the same. So the same issue that had to be solved on i?86, ia64 and rs6000 for _Float64x vs. long double is a problem on arm and aarch64 with _Float16 vs. __fp16. The following patch fixes it so far for aarch64. 2022-09-30 Jakub Jelinek PR c++/107080 * config/aarch64/aarch64.cc (aarch64_mangle_type): Mangle just __fp16 as Dh and _Float16 as DF16_. * g++.target/aarch64/pr107080.C: New test.=