From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 889183858D32; Fri, 31 Mar 2023 22:45:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 889183858D32
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1680302732;
	bh=Zu2Sc5lpOpbzZNj4mkfbaI26qu7S1+rz3gBX/HLzU3g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=pW/Jp2YzRcyQ6neFypFE6GzgLiV/zMxQE9u80vGFynm92Z8WYhujjtrLq4Jfs5zOI
	 zwI87g9SVwC+Ar1Uf840pcsWPYmO1KBwFHa7itH74CYESSk59WtliZ5U8whcRpNrO3
	 L/Q6L2ZQv1tm0sBASjAoO4AKSjk7EoIsDPXvFJcI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107087] [12/13 Regression]
 bits/stl_algobase.h:431: warning: 'void* __builtin_memcpy(void*, const void*,
 unsigned int)' reading between 8 and 2147483644 bytes from a region of size 4
 [-Wstringop-overread]
Date: Fri, 31 Mar 2023 22:45:31 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: diagnostic, missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107087-4-R6ZKFx9vH6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107087-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107087-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107087

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:4969dcd2b7a94ce6c0d07225b21b5f3c040a4902

commit r13-6962-g4969dcd2b7a94ce6c0d07225b21b5f3c040a4902
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Mar 31 13:44:04 2023 +0100

    libstdc++: Teach optimizer that empty COW strings are empty [PR107087]

    The compiler doesn't know about the invariant that the _S_empty_rep()
    object is immutable and so _M_length and _M_refcount are always zero.
    This means that we get warnings about writing possibly-non-zero length
    strings into buffers that can't hold them. If we teach the compiler that
    the empty rep is always zero length, it knows it can be copied into any
    buffer.

    For Stage 1 we might want to also consider adding this to capacity():

            if (_S_empty_rep()._M_capacity !=3D 0)
              __builtin_unreachable();

    And this to _Rep::_M_is_leaked() and _Rep::_M_is_shared():

              if (_S_empty_rep()._M_refcount !=3D 0)
                __builtin_unreachable();

    libstdc++-v3/ChangeLog:

            PR tree-optimization/107087
            * include/bits/cow_string.h (basic_string::size()): Add
            optimizer hint that _S_empty_rep()._M_length is always zero.
            (basic_string::length()): Call size().=