From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id F2A5F3858CDB; Fri, 30 Sep 2022 11:49:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2A5F3858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1664538593; bh=ZkDX9djjQh7gKEHxEmEwDE/WKJhiFUVSvEmrI8D0yo0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JSd+qUH5EHrX0XZVN5NCaNyLp1AOPe9vVJ/ufUeoF3kF2okA2MQqW+9L4TVDbT2BX ZZ5olVX7u4thRKslUPYC7h9vcPeBmJrEW7MhU3xsi5/jSZ7DYtErUbCop+4YpwkD6I zWjwWRsoqhyh/vWHv9WJKabf0TM1pKQlHSxmD9C0= From: "rsandifo at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/107088] [13 Regression] cselib ICE building __trunctfxf2 on ia64 Date: Fri, 30 Sep 2022 11:49:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: rsandifo at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107088 --- Comment #8 from rsandifo at gcc dot gnu.org --- (In reply to Stefan Schulze Frielinghaus from comment #6) > I did a quick test using >=20 > diff --git a/gcc/cselib.cc b/gcc/cselib.cc > index 9b582e5d3d6..2fd0190bc79 100644 > --- a/gcc/cselib.cc > +++ b/gcc/cselib.cc > @@ -1571,6 +1571,7 @@ new_cselib_val (unsigned int hash, machine_mode mod= e, > rtx x) >=20=20 > scalar_int_mode int_mode; > if (REG_P (x) && is_int_mode (mode, &int_mode) > + && int_mode !=3D BImode > && REG_VALUES (REGNO (x)) !=3D NULL > && (!cselib_current_insn || !DEBUG_INSN_P (cselib_current_insn))) > { >=20=20=20=20=20=20 > which solved the cross ia64 build for me. Maybe there are further integer > modes which I didn't consider, i.e., I will have a thorough look at it ne= xt > week. Looks good, but maybe: GET_MODE_SIZE (int_mode) > 1 would be more general. BImode being MODE_INT is a horrible wart (it should be MODE_PARTIAL_INT instead). But unfortunately ia64 is the target that would be most affected by "fixing" this, and it's not an easy target to test. So I think in practice nothing will change while ia64 is the in tree.=