public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "unlvsur at live dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/107167] It looks like GCC wastes registers on trivial computations when result can be cached
Date: Thu, 06 Oct 2022 06:00:40 +0000 [thread overview]
Message-ID: <bug-107167-4-oiGctYq2MQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107167-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107167
--- Comment #2 from cqwrteur <unlvsur at live dot com> ---
(In reply to Andrew Pinski from comment #1)
> This is a reassociation, scheduling issue and register allocation issue.
>
> Plus your example might be slower due to dependencies.
>
> Without a full example of where gcc ra goes wrong, gcc actually produces
> much better code for this example due to register renaming in hw.
> Note many x86_64 also does register renaming for the stack too
The problem I do things like sha512_round:
sha512_round(x[0]=big_endian(W[0]),a,b,d,e,f,g,h,bpc,0x428a2f98d728ae22);
sha512_round(x[1]=big_endian(W[1]),h,a,c,d,e,f,g,bpc,0x7137449123ef65cd);
sha512_round(x[2]=big_endian(W[2]),g,h,b,c,d,e,f,bpc,0xb5c0fbcfec4d3b2f);
sha512_round(x[3]=big_endian(W[3]),f,g,a,b,c,d,e,bpc,0xe9b5dba58189dbbc);
sha512_round(x[4]=big_endian(W[4]),e,f,h,a,b,c,d,bpc,0x3956c25bf348b538);
They use tons of registers. If GCC wastes registers, tons of time would waste
on stack push/load.
My implementation by GCC on x86_64 is slower than openssl's asm version
particularly due to this reason. GCC just pushes/stores too many values on the
stack.
https://github.com/openssl/openssl/blob/master/crypto/sha/asm/sha512-x86_64.pl#L192
OpenSSL does exactly what I do here.
next prev parent reply other threads:[~2022-10-06 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:33 [Bug rtl-optimization/107167] New: " unlvsur at live dot com
2022-10-06 5:55 ` [Bug rtl-optimization/107167] " pinskia at gcc dot gnu.org
2022-10-06 6:00 ` unlvsur at live dot com [this message]
2022-10-06 6:03 ` unlvsur at live dot com
2022-10-06 6:05 ` unlvsur at live dot com
2022-10-06 6:47 ` pinskia at gcc dot gnu.org
2022-10-07 1:41 ` unlvsur at live dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107167-4-oiGctYq2MQ@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).