public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107195] [13 Regression] wrong code with "-O1 -fno-tree-ccp" on x86_64-linux-gnu since r13-3090-gdf4c584c567263fd
Date: Tue, 11 Oct 2022 08:31:57 +0000	[thread overview]
Message-ID: <bug-107195-4-hRmW8R6C5v@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107195-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107195

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:

https://gcc.gnu.org/g:c4d15dddf6b9eacb36f535807ad2ee364af46e04

commit r13-3217-gc4d15dddf6b9eacb36f535807ad2ee364af46e04
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Mon Oct 10 20:42:10 2022 +0200

    [PR107195] Set range to zero when nonzero mask is 0.

    When solving 0 = _15 & 1, we calculate _15 as:

            [irange] int [-INF, -2][0, +INF] NONZERO 0xfffffffe

    The known value of _15 is [0, 1] NONZERO 0x1 which is intersected with
    the above, yielding:

            [0, 1] NONZERO 0x0

    This eventually gets copied to a _Bool [0, 1] NONZERO 0x0.

    This is problematic because here we have a bool which is zero, but
    returns false for irange::zero_p, since the latter does not look at
    nonzero bits.  This causes logical_combine to assume the range is
    not-zero, and all hell breaks loose.

    I think we should just normalize a nonzero mask of 0 to [0, 0] at
    creation, thus avoiding all this.

            PR tree-optimization/107195

    gcc/ChangeLog:

            * value-range.cc (irange::set_range_from_nonzero_bits): Set range
            to [0,0] when nonzero mask is 0.

    gcc/testsuite/ChangeLog:

            * gcc.dg/tree-ssa/pr107195-1.c: New test.
            * gcc.dg/tree-ssa/pr107195-2.c: New test.

  parent reply	other threads:[~2022-10-11  8:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 13:01 [Bug tree-optimization/107195] New: wrong code with "-O1 -fno-tree-ccp" on x86_64-linux-gnu zhendong.su at inf dot ethz.ch
2022-10-09 18:59 ` [Bug tree-optimization/107195] " pinskia at gcc dot gnu.org
2022-10-09 18:59 ` [Bug tree-optimization/107195] [13 Regression] " pinskia at gcc dot gnu.org
2022-10-09 19:01 ` pinskia at gcc dot gnu.org
2022-10-10  7:24 ` rguenth at gcc dot gnu.org
2022-10-10 13:23 ` [Bug tree-optimization/107195] [13 Regression] wrong code with "-O1 -fno-tree-ccp" on x86_64-linux-gnu since r13-3090-gdf4c584c567263fd marxin at gcc dot gnu.org
2022-10-10 18:49 ` aldyh at gcc dot gnu.org
2022-10-10 18:52 ` aldyh at gcc dot gnu.org
2022-10-10 18:53 ` aldyh at gcc dot gnu.org
2022-10-11  8:31 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-11  9:02 ` aldyh at gcc dot gnu.org
2022-10-12  7:48 ` marxin at gcc dot gnu.org
2022-10-21  9:29 ` cvs-commit at gcc dot gnu.org
2022-10-21  9:29 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107195-4-hRmW8R6C5v@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).