public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktkachov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/107209] [13 Regression] ICE: verify_gimple failed (error: statement marked for throw, but doesn't)
Date: Tue, 20 Dec 2022 09:22:49 +0000 [thread overview]
Message-ID: <bug-107209-4-Edk21Ib0oA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107209-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107209
--- Comment #5 from ktkachov at gcc dot gnu.org ---
(In reply to Jakub Jelinek from comment #4)
> Looking at other backends, rs6000 uses in *gimple_fold_builtin gsi_replace
> (..., true);
> all the time, ix86 gsi_replace (..., false); all the time, alpha with true,
> aarch64 with true. But perhaps what is more important if the builtins
> folded are declared nothrow or not, if they are nothrow, then they shouldn't
> have any EH edges at the start already and so it shouldn't matter what is
> used.
The vmulx_f64 intrinsic is not marked "nothrow" by the logic:
1284 static tree
1285 aarch64_get_attributes (unsigned int f, machine_mode mode)
1286 {
1287 tree attrs = NULL_TREE;
1288
1289 if (!aarch64_modifies_global_state_p (f, mode))
1290 {
1291 if (aarch64_reads_global_state_p (f, mode))
1292 attrs = aarch64_add_attribute ("pure", attrs);
1293 else
1294 attrs = aarch64_add_attribute ("const", attrs);
1295 }
1296
1297 if (!flag_non_call_exceptions || !aarch64_could_trap_p (f, mode))
1298 attrs = aarch64_add_attribute ("nothrow", attrs);
1299
1300 return aarch64_add_attribute ("leaf", attrs);
1301 }
aarch64_could_trap_p returns true for it as it can raise an FP exception.
Should that affect the nothrow attribute though? Shouldn't that be for C++
exceptions only?
next prev parent reply other threads:[~2022-12-20 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 4:29 [Bug tree-optimization/107209] New: " asolokha at gmx dot com
2022-10-11 7:27 ` [Bug tree-optimization/107209] " rguenth at gcc dot gnu.org
2022-10-11 15:57 ` pinskia at gcc dot gnu.org
2022-10-18 8:08 ` rguenth at gcc dot gnu.org
2022-10-18 8:29 ` [Bug target/107209] " rguenth at gcc dot gnu.org
2022-11-30 17:26 ` jakub at gcc dot gnu.org
2022-12-20 9:22 ` ktkachov at gcc dot gnu.org [this message]
2022-12-20 9:29 ` jakub at gcc dot gnu.org
2023-01-13 10:01 ` cvs-commit at gcc dot gnu.org
2023-01-13 10:09 ` rsandifo at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107209-4-Edk21Ib0oA@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).