public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/107236] [OpenMP] ICE for reverse offload: in expand_GOMP_TARGET_REV, at internal-fn.cc:376
Date: Mon, 24 Oct 2022 13:20:38 +0000	[thread overview]
Message-ID: <bug-107236-4-R0hVaYECv8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107236-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107236

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:178ac530fe67e4f2fc439cc4ce89bc19d571ca31

commit r13-3455-g178ac530fe67e4f2fc439cc4ce89bc19d571ca31
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon Oct 24 15:19:00 2022 +0200

    OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236]

    For 'target parallel' and similarly nested directives, cgraph_node's
    calls_declare_variant_alt was not set in the parent region node but in
    cfun->decl. Hence, pass_omp_device_lower did not process handle the
    internal function GOMP_TARGET_REV. - Solution is to set it to the
    DECL_CONTEXT, which is set in adjust_context_and_scope.

    The cgraph_node::create_clone issue is exposed with -O2 for the existing
    libgomp.fortran/reverse-offload-1.f90.

            PR middle-end/107236

    gcc/ChangeLog:
            * omp-expand.cc (expand_omp_target): Set calls_declare_variant_alt
            in DECL_CONTEXT and not to cfun->decl.
            * cgraphclones.cc (cgraph_node::create_clone): Copy also the
            node's calls_declare_variant_alt value.

    gcc/testsuite/ChangeLog:
            * gfortran.dg/gomp/target-device-ancestor-6.f90: New test.

  parent reply	other threads:[~2022-10-24 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 13:35 [Bug middle-end/107236] New: " burnus at gcc dot gnu.org
2022-10-12 13:47 ` [Bug middle-end/107236] " burnus at gcc dot gnu.org
2022-10-24 13:20 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-24 13:25 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107236-4-R0hVaYECv8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).