public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/107240] [13 Regression] FAIL: gcc.dg/vect/vect-bitfield-write-2.c since r13-3219-g25413fdb2ac249 Date: Mon, 17 Oct 2022 04:04:11 +0000 [thread overview] Message-ID: <bug-107240-4-JN0qxAGRtu@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107240-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107240 Kewen Lin <linkw at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |linkw at gcc dot gnu.org --- Comment #6 from Kewen Lin <linkw at gcc dot gnu.org> --- The reason why it fails on power7 is that power7 misses the vector/vector shift support for V2DImode (type vector(2) long unsigned int), the support querying is for the gimple statement: patt_25 = 5 << 28; It's expected since vsld is supported till ISA 2.07 (power8) (Note that we have vslb/vslh/vslw since ISA 2.03). But you might have noticed that both shifted value and shifting count are constants for this particular test case, so it doesn't need the actual vector/vector shift target support here. One tiny enhancement as below can make us not need to special case this for Power port. diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 0cc315d3126..01d043a3d18 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -2115,9 +2115,10 @@ vect_recog_bit_insert_pattern (vec_info *vinfo, stmt_vec_info stmt_info, tree shifted = value; if (shift_n) { + tree shifted_value = fold_build2 (LSHIFT_EXPR, container_type, value, shift); pattern_stmt = gimple_build_assign (vect_recog_temp_ssa_var (container_type), - LSHIFT_EXPR, value, shift); + shifted_value); append_pattern_def_seq (vinfo, stmt_info, pattern_stmt); shifted = gimple_get_lhs (pattern_stmt); }
next prev parent reply other threads:[~2022-10-17 4:04 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-12 18:48 [Bug testsuite/107240] New: [13 regression] seurer at gcc dot gnu.org 2022-10-12 19:16 ` [Bug testsuite/107240] " bergner at gcc dot gnu.org 2022-10-13 6:49 ` [Bug testsuite/107240] [13 Regression] FAIL: gcc.dg/vect/vect-bitfield-write-2.c since r13-3219-g25413fdb2ac249 marxin at gcc dot gnu.org 2022-10-13 13:53 ` avieira at gcc dot gnu.org 2022-10-14 7:20 ` rguenth at gcc dot gnu.org 2022-10-14 16:44 ` segher at gcc dot gnu.org 2022-10-14 16:45 ` avieira at gcc dot gnu.org 2022-10-14 16:48 ` segher at gcc dot gnu.org 2022-10-17 4:04 ` linkw at gcc dot gnu.org [this message] 2022-10-17 6:21 ` linkw at gcc dot gnu.org 2022-10-18 5:56 ` linkw at gcc dot gnu.org 2022-10-18 8:06 ` rguenth at gcc dot gnu.org 2022-10-20 9:08 ` cvs-commit at gcc dot gnu.org 2022-10-28 3:31 ` cvs-commit at gcc dot gnu.org 2022-10-28 3:44 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107240-4-JN0qxAGRtu@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).