public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107312] [13 Regression] ICE in verify_range, at value-range.cc:1172, called from range_true_and_false since r13-3193-g8b6bcedc88d54415
Date: Wed, 19 Oct 2022 14:01:51 +0000	[thread overview]
Message-ID: <bug-107312-4-qxLTDabTCE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107312-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107312

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:

https://gcc.gnu.org/g:d32969898e113e86e1c42b0c6f096f8228cbf1ff

commit r13-3382-gd32969898e113e86e1c42b0c6f096f8228cbf1ff
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Wed Oct 19 14:27:46 2022 +0200

    [PR tree-optimization/107312] Make range_true_and_false work with 1-bit
signed types.

    range_true_and_false() returns a range of [0,1], which for a 1-bit
    signed integer gets passed to the irange setter as [0, -1].  These
    endpoints are out of order and cause an ICE.  Through some dumb luck,
    the legacy code swaps out of order endpoints, because old VRP would
    sometimes pass endpoints reversed, depending on the setter to fix
    them.  This swapping does not happen for non-legacy, hence the ICE.

    The right thing to do (apart from killing legacy and 1-bit signed
    integers ;-)), is to avoid passing out of order endpoints for 1-bit
    signed integers.  For that matter, a range of [-1, 0] (signed) or
    [0, 1] (unsigned) is just varying.

            PR tree-optimization/107312

    gcc/ChangeLog:

            * range.h (range_true_and_false): Special case 1-bit signed types.
            * value-range.cc (range_tests_misc): New test.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr107312.c: New test.

  parent reply	other threads:[~2022-10-19 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  3:04 [Bug tree-optimization/107312] New: [13 Regression] ICE in verify_range, at value-range.cc:1172, called from range_true_and_false asolokha at gmx dot com
2022-10-19  6:54 ` [Bug tree-optimization/107312] [13 Regression] ICE in verify_range, at value-range.cc:1172, called from range_true_and_false since r13-3193-g8b6bcedc88d54415 marxin at gcc dot gnu.org
2022-10-19  7:24 ` rguenth at gcc dot gnu.org
2022-10-19 13:04 ` aldyh at gcc dot gnu.org
2022-10-19 13:06 ` aldyh at gcc dot gnu.org
2022-10-19 14:01 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-19 14:03 ` aldyh at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107312-4-qxLTDabTCE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).