From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id F23F3385800F; Tue, 25 Oct 2022 05:20:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F23F3385800F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1666675210;
	bh=60Jbb33hMTz/eXJmF7TuLfG5upUOW5MHp1yWB3/aXAI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=nyqq4Qybcozvm4roilnprxDuHyqH9UnyemRoA7WoWiASXNAnpP47fi7R0Y1u6dWhv
	 lYByZDERRLUhky4ZCoGwNdojuuk+VCxRIYOz1Y5e5DKKWL3Ov04Sn4m5OawxrQ+yuz
	 jC46I3Cd7c0M2Bu6UpcvMrZi/24hKWF67QeUc2S0=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/107338] new test case
 gcc.dg/vect/vect-bitfield-read-7.c in r13-3413-ge10ca9544632db fails
Date: Tue, 25 Oct 2022 05:20:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: testsuite-fail
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107338-4-ZSH0G4gMBs@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107338-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107338-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107338

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:958014f369c8817184af110f8eb2c433a712fd0a

commit r13-3474-g958014f369c8817184af110f8eb2c433a712fd0a
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Tue Oct 25 00:18:08 2022 -0500

    vect: Fix wrong shift_n after widening on BE [PR107338]

    As PR107338 shows, with the use of widening loads, the
    container_type can become a wider type, it causes us to
    get wrong shift_n since the BIT_FIELD_REF offset actually
    becomes bigger on BE.  Taking the case in PR107338 as
    example, at the beginning the container type is short and
    BIT_FIELD_REF offset is 8 and size is 4, with unpacking to
    wider type int, the high 16 bits are zero, by viewing it
    as type int, its offset actually becomes to 24.  So the
    shift_n should be 4 (32 - 24 - 4) instead of 20 (32 - 8
    - 4).

    I noticed that if we move shift_n calculation early
    before the adjustments for widening loads (container type
    change), it's based on all the stuffs of the original
    container, the shfit_n calculated there is exactly what
    we want, it can be independent of widening.  Besides, I
    add prec adjustment together with the current adjustments
    for widening loads, although prec's subsequent uses don't
    require this change for now, since the container type gets
    changed, we should keep the corresponding prec consistent.

            PR tree-optimization/107338

    gcc/ChangeLog:

            * tree-vect-patterns.cc (vect_recog_bitfield_ref_pattern): Move
            shfit_n calculation before the adjustments for widening loads.=