public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/107353] [13 regression] Numerous ICEs after r13-3416-g1d561e1851c466
Date: Sat, 22 Oct 2022 11:17:39 +0000	[thread overview]
Message-ID: <bug-107353-4-jTaONbVckb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107353-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107353

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
Emulated TLS targets can test targetm.have_tls.

The patch below fixes the fails on Fortran for x86_64-darwin, libgomp in test
now.

I do not really like that it means pulling in the whole of target.h, and
imagine that this will not fix the powerpc64le-linux-gnu cases?

The TLS varieties are "ELF" (AFAIU).. so this would not fix things if/when I
implement native TLS on Darwin (since that has Mach-O semantics for TLS).

so, perhaps there's a better test (or we should make the targetm test more
fine-grained).  In any event we should not test things that pertain to the
platform in the inner loop - but either punt on the whole opt (or choose a
different flavour) for other targets.


diff --git a/gcc/ipa-visibility.cc b/gcc/ipa-visibility.cc
index 3ed2b7cf679..acea49f8b1f 100644
--- a/gcc/ipa-visibility.cc
+++ b/gcc/ipa-visibility.cc
@@ -86,6 +86,7 @@ along with GCC; see the file COPYING3.  If not see
 #include "ipa-utils.h"
 #include "stringpool.h"
 #include "attribs.h"
+#include "target.h"

 /* Return true when NODE cannot be local. Worker for cgraph_local_node_p.  */

@@ -873,7 +874,7 @@ function_and_variable_visibility (bool whole_program)
        }
     }

-  if (symtab->state >= IPA_SSA)
+  if (symtab->state >= IPA_SSA && targetm.have_tls)
     {
       FOR_EACH_VARIABLE (vnode)
        {

  parent reply	other threads:[~2022-10-22 11:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 22:53 [Bug other/107353] New: [13 regression] Numerous ICEs after 13-3416-g1d561e1851c466 seurer at gcc dot gnu.org
2022-10-21 22:56 ` [Bug other/107353] " seurer at gcc dot gnu.org
2022-10-21 23:30 ` law at gcc dot gnu.org
2022-10-22  8:49 ` [Bug other/107353] [13 regression] Numerous ICEs after r13-3416-g1d561e1851c466 iains at gcc dot gnu.org
2022-10-22 11:17 ` iains at gcc dot gnu.org [this message]
2022-10-24 13:00 ` rguenth at gcc dot gnu.org
2022-10-24 20:42 ` segher at gcc dot gnu.org
2022-10-25  6:43 ` amonakov at gcc dot gnu.org
2022-10-25  6:54 ` asolokha at gmx dot com
2022-10-25  7:00 ` amonakov at gcc dot gnu.org
2022-10-25  7:11 ` amonakov at gcc dot gnu.org
2022-10-25  7:49 ` asolokha at gmx dot com
2022-10-25 14:11 ` amonakov at gcc dot gnu.org
2022-10-25 16:08 ` amonakov at gcc dot gnu.org
2022-10-25 17:51 ` amonakov at gcc dot gnu.org
2022-10-26 16:30 ` cvs-commit at gcc dot gnu.org
2022-10-26 17:02 ` [Bug other/107353] frontends sometimes select wrong (too strong) TLS access model amonakov at gcc dot gnu.org
2023-04-26  6:56 ` rguenth at gcc dot gnu.org
2023-07-27  9:24 ` rguenth at gcc dot gnu.org
2024-05-21  9:12 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107353-4-jTaONbVckb@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).