public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dani at danielbertalan dot dev" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" Date: Sun, 23 Oct 2022 09:43:04 +0000 [thread overview] Message-ID: <bug-107363-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363 Bug ID: 107363 Summary: Wrong caret location for "redundant move in return statement" Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c++ Assignee: unassigned at gcc dot gnu.org Reporter: dani at danielbertalan dot dev Target Milestone: --- The caret in the following "redundant move in return statement" warning does not point to a return statement (https://godbolt.org/z/4v7Y9G9e3): ``` #include <utility> template <typename T> struct Optional { T &value(); T release_value() { T released_value = std::move(value()); return released_value; } }; struct Foo {}; void test(Optional<const Foo> o) { o.release_value(); } ``` <source>:7:7: warning: redundant move in return statement [-Wredundant-move] 7 | T released_value = std::move(value()); | ^~~~~~~~~~~~~~ <source>:7:7: note: remove 'std::move' call As an aside, it's a bit annoying to have this warning when the moved type depends on a template parameter in library code. We are forced to either silence this warning with a #pragma, or use concepts to have a variant of the release_value method that does not call std::move for const-qualified T.
next reply other threads:[~2022-10-23 9:43 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-23 9:43 dani at danielbertalan dot dev [this message] 2022-10-23 15:52 ` [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo pinskia at gcc dot gnu.org 2022-10-24 16:34 ` mpolacek at gcc dot gnu.org 2022-11-09 2:37 ` cvs-commit at gcc dot gnu.org 2022-11-09 2:52 ` mpolacek at gcc dot gnu.org 2022-11-28 22:17 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107363-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).