public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/107366] -fanalyzer with -fdiagnostics-format=sarif-file or sarif-stderr
Date: Mon, 24 Oct 2022 07:47:48 +0000	[thread overview]
Message-ID: <bug-107366-4-go8taNferI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107366-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107366

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Potential fix:

diff --git a/gcc/diagnostic-format-sarif.cc b/gcc/diagnostic-format-sarif.cc
index fc28d160c38..7110db4edd6 100644
--- a/gcc/diagnostic-format-sarif.cc
+++ b/gcc/diagnostic-format-sarif.cc
@@ -595,7 +595,7 @@ sarif_builder::make_location_object (const diagnostic_event
&event)
 json::object *
 sarif_builder::maybe_make_physical_location_object (location_t loc)
 {
-  if (loc <= BUILTINS_LOCATION)
+  if (loc <= BUILTINS_LOCATION || LOCATION_FILE (loc) == NULL)
     return NULL;

   json::object *phys_loc_obj = new json::object ();

  parent reply	other threads:[~2022-10-24  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-23 12:15 [Bug c/107366] New: " rainer.keller@hs-esslingen.de
2022-10-24  7:38 ` [Bug analyzer/107366] " marxin at gcc dot gnu.org
2022-10-24  7:46 ` marxin at gcc dot gnu.org
2022-10-24  7:47 ` marxin at gcc dot gnu.org [this message]
2022-10-24 15:13 ` [Bug analyzer/107366] ICE with " dmalcolm at gcc dot gnu.org
2022-10-24 20:49 ` cvs-commit at gcc dot gnu.org
2022-10-24 21:02 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107366-4-go8taNferI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).