public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107407] [12/13 Regression] Wrong code at -Os on x86_64-linux-gnu since r12-383-g32955416d8040b1f
Date: Fri, 28 Oct 2022 13:40:19 +0000	[thread overview]
Message-ID: <bug-107407-4-SYN7G4AIV1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107407-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107407

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:031a400e49d8db156c43f9ec0b21ab0c2aee8c6d

commit r13-3546-g031a400e49d8db156c43f9ec0b21ab0c2aee8c6d
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Oct 28 15:03:49 2022 +0200

    tree-optimization/107407 - wrong code with DSE

    So what happens is that we elide processing of this check with

              /* In addition to kills we can remove defs whose only use
                 is another def in defs.  That can only ever be PHIs of which
                 we track two for simplicity reasons, the first and last in
                 {first,last}_phi_def (we fail for multiple PHIs anyways).
                 We can also ignore defs that feed only into
                 already visited PHIs.  */
              else if (single_imm_use (vdef, &use_p, &use_stmt)
                       && (use_stmt == first_phi_def
                           || use_stmt == last_phi_def
                           || (gimple_code (use_stmt) == GIMPLE_PHI
                               && bitmap_bit_p (visited,
                                                SSA_NAME_VERSION
                                                  (PHI_RESULT (use_stmt))))))

    where we have the last PHI being the outer loop virtual PHI and the first
    PHI being the loop exit PHI of the outer loop and we've already processed
    the single immediate use of the outer loop PHI, the inner loop PHI.  But
    we still have to perform the above check!

    It's easiest to perform the check when we visit the PHI node instead of
    delaying it to the actual processing loop.

            PR tree-optimization/107407
            * tree-ssa-dse.cc (dse_classify_store): Perform backedge
            varying index check when collecting PHI uses rather than
            after optimizing processing of the candidate defs.

            * gcc.dg/torture/pr107407.c: New testcase.

  parent reply	other threads:[~2022-10-28 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  7:44 [Bug c/107407] New: Wrong code at -Os on x86_64-linux-gnu shaohua.li at inf dot ethz.ch
2022-10-26  8:03 ` [Bug tree-optimization/107407] [12/13 Regression] Wrong code at -Os on x86_64-linux-gnu since r12-383-g32955416d8040b1f marxin at gcc dot gnu.org
2022-10-26  8:03 ` marxin at gcc dot gnu.org
2022-10-26 17:00 ` pinskia at gcc dot gnu.org
2022-10-28  9:48 ` rguenth at gcc dot gnu.org
2022-10-28 13:03 ` rguenth at gcc dot gnu.org
2022-10-28 13:40 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-28 13:43 ` [Bug tree-optimization/107407] [12 " rguenth at gcc dot gnu.org
2022-12-12 11:20 ` cvs-commit at gcc dot gnu.org
2022-12-12 11:21 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107407-4-SYN7G4AIV1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).