From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 410563851506; Fri, 28 Oct 2022 13:03:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 410563851506
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1666962186;
	bh=EJZYJsjyAVV/ewTMr5Hvrylvpi2Bw40BMb2alXKCoZM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=kVPkjbqOgN+iMGiAVi3FAVzuzmaJ3smgsc57hbNH05EtLIrGbLx92uBgtslso6i9i
	 NiiAcM3CVHAirHICJYcuZjbKlHusX2Y3kw/fV0xbKvU+BSFshAmqb4V6skF3c7usWD
	 02lTN1Xja/GXlWKsyEuLG9cJYhLfrodqBJtuiA0w=
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107407] [12/13 Regression] Wrong code at -Os
 on x86_64-linux-gnu since r12-383-g32955416d8040b1f
Date: Fri, 28 Oct 2022 13:03:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107407-4-bb7nkeHGTx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107407-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107407-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107407

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
  Deleted dead store: MEM <int[4]> [(int *)&c][_6] =3D 3;

Further reduced testcase, we mistreat SSA name indexes with must aliases.
We do have

          /* If we visit this PHI by following a backedge then we have to
             make sure ref->ref only refers to SSA names that are invariant
             with respect to the loop represented by this PHI node.  */
          if (dominated_by_p (CDI_DOMINATORS, gimple_bb (stmt),
                              gimple_bb (temp))
              && !for_each_index (ref->ref ? &ref->ref : &ref->base,
                                  check_name, gimple_bb (temp)))
            return DSE_STORE_LIVE;

that is supposed to catch this but somehow it doesn't trigger here.

int *a;
int c[4];
int d;

static int
f(char k, int j)
{
  for (; k <=3D 3; k++)
    {
      a =3D &c[k];
      for (; d <=3D 1; d++)
        *a =3D 3;
    }
  *a =3D 0;
}

int main()
{
  int i;
  f(0, 0);
  if (c[0] !=3D 3)
    __builtin_abort ();
}


So what happens is that we elide processing of this check with

          /* In addition to kills we can remove defs whose only use
             is another def in defs.  That can only ever be PHIs of which
             we track two for simplicity reasons, the first and last in
             {first,last}_phi_def (we fail for multiple PHIs anyways).
             We can also ignore defs that feed only into
             already visited PHIs.  */
          else if (single_imm_use (vdef, &use_p, &use_stmt)
                   && (use_stmt =3D=3D first_phi_def
                       || use_stmt =3D=3D last_phi_def
                       || (gimple_code (use_stmt) =3D=3D GIMPLE_PHI
                           && bitmap_bit_p (visited,
                                            SSA_NAME_VERSION
                                              (PHI_RESULT (use_stmt))))))

where we have the last PHI being the outer loop virtual PHI and the first
PHI being the loop exit PHI of the outer loop and we've already processed
the single immediate use of the outer loop PHI, the inner loop PHI.  But
we still have to perform the above check!

It's easiest to perform the check when we visit the PHI node instead of
delaying it to the actual processing loop.=