public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/107417] g++ fails to recognize parameter pack in requires-expression
Date: Sun, 04 Dec 2022 15:47:36 +0000	[thread overview]
Message-ID: <bug-107417-4-QGX5vINM72@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107417-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107417

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:079add3ad39d6620d34665dd9c26c21951eb657c

commit r13-4483-g079add3ad39d6620d34665dd9c26c21951eb657c
Author: Patrick Palka <ppalka@redhat.com>
Date:   Sun Dec 4 10:47:24 2022 -0500

    c++: pack in requires-expr parm list [PR107417]

    Here find_parameter_packs_r isn't detecting the pack T inside the
    requires-expr's parameter list ultimately because cp_walk_trees
    deliberately avoids walking the list so as to avoid false positives in
    the unexpanded pack checker.

    But it should still be fine to walk the TREE_TYPE of each parameter,
    which we already need to do from for_each_template_parm_r, and is
    sufficient to fix the testcase.

            PR c++/107417

    gcc/cp/ChangeLog:

            * pt.cc (for_each_template_parm_r) <case REQUIRES_EXPR>: Move
            walking of the TREE_TYPE of each parameter to ...
            * tree.cc (cp_walk_subtrees) <case REQUIRES_EXPR>: ... here.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/concepts-requires33.C: New test.

  parent reply	other threads:[~2022-12-04 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:25 [Bug c++/107417] New: " jwjagersma at gmail dot com
2022-10-26 16:32 ` [Bug c++/107417] " redi at gcc dot gnu.org
2022-10-26 19:06 ` ppalka at gcc dot gnu.org
2022-12-04 15:47 ` cvs-commit at gcc dot gnu.org [this message]
2022-12-04 15:47 ` ppalka at gcc dot gnu.org
2022-12-19 16:54 ` cvs-commit at gcc dot gnu.org
2022-12-19 16:56 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107417-4-QGX5vINM72@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).