From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A7CD23858412; Fri, 22 Mar 2024 13:33:03 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7CD23858412
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1711114383;
	bh=UrNqJ9YkHFJVUXR9FRKnINUAk0HiTOJiVGqH4rxi1xE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=SQuknu1Cv9OLm21Fa7snzdOtQFIuNjWNS64DZChXeeOzAq7RPrGQuk4S70vUAwCmC
	 zJrJGaLV4jvoaaA6/iYypJ8mnDDrsCxBv2s7gqYknwhc0y2cPl1OeYkWnh9GnNjQsk
	 2WPyBSWh71sihAypkguxTJQNu7fRV024bmGhPaVU=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107426] [12/13/14 Regression] ICE in
 gfc_compare_derived_types, at fortran/interface.cc:636
Date: Fri, 22 Mar 2024 13:33:00 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-107426-4-glbAHX3Blj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-107426-4@http.gcc.gnu.org/bugzilla/>
References: <bug-107426-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107426

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mikael Morin <mikael@gcc.gnu.org>:

https://gcc.gnu.org/g:a44d7e8a52007c2d45217709ca02947c6600de87

commit r14-9619-ga44d7e8a52007c2d45217709ca02947c6600de87
Author: Mikael Morin <mikael@gcc.gnu.org>
Date:   Thu Mar 21 17:27:54 2024 +0100

    fortran: Ignore use statements on error [PR107426]

    This fixes an access to freed memory on the testcase from the PR.
    The problem comes from an invalid subroutine statement in an interface,
    which is ignored and causes the following statements forming the proced=
ure
    body to be rejected.  One of them use-associates the intrinsic
ISO_C_BINDING
    module, which imports new symbols in a namespace that is freed at the t=
ime
    the statement is rejected.  However, this creates dangling pointers as
    ISO_C_BINDING is special and its import creates a reference to the impo=
rted
    C_PTR symbol in the return type of the global intrinsic symbol for C_LOC
    (see the function create_intrinsic_function).

    This change saves and restores the list of use statements, so that reje=
cted
    use statements are removed before they have a chance to be applied to t=
he
    current namespace and create dangling pointers.

            PR fortran/107426

    gcc/fortran/ChangeLog:

            * gfortran.h (gfc_save_module_list, gfc_restore_old_module_list=
):
            New declarations.
            * module.cc (old_module_list_tail): New global variable.
            (gfc_save_module_list, gfc_restore_old_module_list): New functi=
ons.
            (gfc_use_modules): Set module_list and old_module_list_tail.
            * parse.cc (next_statement): Save module_list before doing any
work.
            (reject_statement): Restore module_list to its saved value.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/pr89943_3.f90: Update error pattern.
            * gfortran.dg/pr89943_4.f90: Likewise.
            * gfortran.dg/use_31.f90: New test.=